Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cpp/abseil-cpp, dev-libs/protobuf, net-libs/grpc: bump packages #31893

Closed
wants to merge 8 commits into from

Conversation

thesamesam
Copy link
Member

This cherry-picks some stuff from other PRs (not all of the commits in them) just to try untangle a bit here:

This still needs a bunch more testing and also @themobiusproject's sign-off for the commits I cherry-picked from him so I can push this.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: ebuilds
Packages affected: dev-cpp/abseil-cpp, dev-libs/protobuf, net-libs/grpc

dev-cpp/abseil-cpp: @gyakovlev
dev-libs/protobuf: @Arfrever, @gentoo/cjk
net-libs/grpc: @perfinion, @gyakovlev, @xen0n

Linked bugs

Bugs linked: 910284, 908372, 908373, 909081, 906811


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 15, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-15 06:35 UTC
Newest commit scanned: 266bfba
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/34bbf20c9a/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-15 07:05 UTC
Newest commit scanned: 1c8bfaf
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a3453e5003/output.html

gentoo-bot pushed a commit that referenced this pull request Aug 21, 2023
abseil isn't *really* intended to be a system library and having a year-old
pinned dep like this causes havoc for other packages and leads to uninstallable
combinations (e.g. libreoffice-bin + anything needing grpc).

Please see also the extensive discussion in the linked PRs wrt abseil now
depending on re2 and the ABI implications of the used C++ std. versions with
abseil. It's not worth it and there's more downsides to unbundling than not.

Note that we can't rebundle re2 here because the build system unconditionally
then tries to install it (no toggle unlike for abseil-cpp).

Bug: https://bugs.gentoo.org/906811
Bug: #31388
Bug: #31609
Bug: #31893
Bug: #32281
Closes: https://bugs.gentoo.org/908373
Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Aug 21, 2023
abseil isn't *really* intended to be a system library and having a year-old
pinned dep like this causes havoc for other packages and leads to uninstallable
combinations (e.g. libreoffice-bin + anything needing grpc).

Please see also the extensive discussion in the linked PRs wrt abseil now
depending on re2 and the ABI implications of the used C++ std. versions with
abseil. It's not worth it and there's more downsides to unbundling than not.

Bug: #31388
Bug: #31609
Bug: #31893
Bug: #32281
Bug: https://bugs.gentoo.org/908373
Closes: https://bugs.gentoo.org/912686
Signed-off-by: Sam James <sam@gentoo.org>
stha09 and others added 8 commits August 21, 2023 16:51
Closes: https://bugs.gentoo.org/908372
Signed-off-by: Stephan Hartmann <sultan@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
I understand that historically the gtest source was required, but I am
able to run the multilib tests successfully on amd64 without them.

Closes: https://bugs.gentoo.org/910284
Signed-off-by: Mark Conway <mark.conway@themobiusproject.com>
Signed-off-by: Sam James <sam@gentoo.org>
Upstream's versioning has change which messes with slot numbers.

Closes: https://bugs.gentoo.org/906811
Signed-off-by: Mark Conway <mark.conway@themobiusproject.com>
Signed-off-by: Sam James <sam@gentoo.org>
Closes: https://bugs.gentoo.org/908373
Signed-off-by: Mark Conway <mark.conway@themobiusproject.com>
Signed-off-by: Sam James <sam@gentoo.org>
Bug: https://bugs.gentoo.org/908373
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-21 16:05 UTC
Newest commit scanned: 8090709
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ecdf9f216f/output.html

MocioF pushed a commit to MocioF/gentoo that referenced this pull request Aug 23, 2023
abseil isn't *really* intended to be a system library and having a year-old
pinned dep like this causes havoc for other packages and leads to uninstallable
combinations (e.g. libreoffice-bin + anything needing grpc).

Please see also the extensive discussion in the linked PRs wrt abseil now
depending on re2 and the ABI implications of the used C++ std. versions with
abseil. It's not worth it and there's more downsides to unbundling than not.

Note that we can't rebundle re2 here because the build system unconditionally
then tries to install it (no toggle unlike for abseil-cpp).

Bug: https://bugs.gentoo.org/906811
Bug: gentoo#31388
Bug: gentoo#31609
Bug: gentoo#31893
Bug: gentoo#32281
Closes: https://bugs.gentoo.org/908373
Signed-off-by: Sam James <sam@gentoo.org>
MocioF pushed a commit to MocioF/gentoo that referenced this pull request Aug 23, 2023
abseil isn't *really* intended to be a system library and having a year-old
pinned dep like this causes havoc for other packages and leads to uninstallable
combinations (e.g. libreoffice-bin + anything needing grpc).

Please see also the extensive discussion in the linked PRs wrt abseil now
depending on re2 and the ABI implications of the used C++ std. versions with
abseil. It's not worth it and there's more downsides to unbundling than not.

Bug: gentoo#31388
Bug: gentoo#31609
Bug: gentoo#31893
Bug: gentoo#32281
Bug: https://bugs.gentoo.org/908373
Closes: https://bugs.gentoo.org/912686
Signed-off-by: Sam James <sam@gentoo.org>
MocioF pushed a commit to MocioF/gentoo that referenced this pull request Aug 23, 2023
Closes: gentoo#31893
Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam thesamesam deleted the abseil-trouble branch September 12, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants