Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-vpn/i2p: use tomcat's jspc #31994

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

net-vpn/i2p: use tomcat's jspc #31994

wants to merge 1 commit into from
+272 −0

Conversation

tharvik
Copy link
Contributor

@tharvik tharvik commented Jul 21, 2023

potential fix for running jspc on arm. as unable to reproduce, waiting for fix confirmation. revbump as potentially generating changed webapp.

shall I remove 2.3.0 in the same PR?

@tharvik
net-vpn/i2p: use tomcat's jspc
23ca36d 
Bug: https://bugs.gentoo.org/910498
Signed-off-by: Valérian Rousset <tharvik@users.noreply.github.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @tharvik
Areas affected: ebuilds
Packages affected: net-vpn/i2p

net-vpn/i2p: @tharvik, @gentoo/java, @gentoo/proxy-maint

Linked bugs

Bugs linked: 910498

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 21, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-21 19:25 UTC
Newest commit scanned: 23ca36d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7a05ad0e18/output.html

@vaukai
Copy link
Contributor

vaukai commented Jul 24, 2023

shall I remove 2.3.0 in the same PR?

You could have done

git mv i2p-2.3.0.ebuild i2p-2.3.0-r1.ebuild

then have added you changes there.

@thesamesam
Copy link
Member

I can't actually reproduce the bug now even without this...

@thesamesam
Copy link
Member

shall I remove 2.3.0 in the same PR?

You could have done

git mv i2p-2.3.0.ebuild i2p-2.3.0-r1.ebuild

then have added you changes there.

Separate commits are better unless it's a trivial and definitely correct change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@tharvik @gentoo-bot @gentoo-repo-qa-bot @vaukai @thesamesam