www-servers/nginx: Add njs module (javascript) #3200
Conversation
|
Pull Request assignment Areas affected: ebuilds, profiles www-servers/nginx: @Whissi, @dev-zero, @jbergstroem |
gentoo-repo-qa-bot
added
the
assigned
|
@burik666 is this really enough? Don't we need a compile flag? |
|
@jbergstroem yes. From njs documentation:
|
|
@burik666 my fault; i didn't notice that github hid the diff for the ebuild. Sorry! |
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
|
@burik666: Thank you for your contribution but we won't add any additional modules: It is too much work for us to keep up with all the modules no developer uses and therefore nobody really cares. For example, if we add this module but it won't work in future, should we hold back a new nginx version just because of this extension (yes, I noticed that this module is from nginx developers but there's a reason why it isn't included per default)? So like we have already denied requests for other modules we have to deny this one as well. I hope you understand. But I got an idea from another dev how we could solve this problem for extensions like yours which can be built as dynamic module and don't require a patched core nor depend on |
Whissi
added
the
do not merge
|
@Whissi: isn't njs core though? edit: moving to modules is something i'd really like to do as well. we should look at freebsd's portfile. |
|
Like said there's a reason why upstream decided not to merge njs with nginx core (yet?). If the current experiment will fail (we don't follow FreeBSD because FreeBSD is maintaining everything in their main nginx Makefile... currently working on something like the mod_apache thing with a nginx eclass involved, looks promising at the moment.. thought we had more modules requiring a patched core but this isn't the case) and we don't have solution until 2017-01-31 we will re-consider the situation and add a bunch of long requested modules (including this one). But I am very positive that we will have a working solution in near future to maintain extension in their own ebuild. |
|
@Whissi, ping. It seems that the deadline has passed and nobody replied here. What's the status? Do we rebase it or reject it? |
|
I have the changes in my overlay. I hope to get this moved into the main repository this month. |
Ebuild changes: =============== - LDAP auth module bumped to commit 42d195d7a7575ebab1c369ad3fc5d78dc2c2669c to add OpenSSL 1.1.x support and other bugfixes. - HTTP upstream check module bumped to commit 9aecf15ec379fe98f62355c57b60c0bc83296f04 to fix possible segfault when reloading configuration. - Virtual host traffic status module added. - nginScript module added. [PR 3200] - Brotli module added. [Bug 628898] See: #3200 Closes: https://bugs.gentoo.org/628898 Package-Manager: Portage-2.3.24, Repoman-2.3.6
Ebuild changes: =============== - LDAP auth module bumped to commit 42d195d7a7575ebab1c369ad3fc5d78dc2c2669c to add OpenSSL 1.1.x support and other bugfixes. - HTTP upstream check module bumped to commit 9aecf15ec379fe98f62355c57b60c0bc83296f04 to fix possible segfault when reloading configuration. - Virtual host traffic status module added. - nginScript module added. [PR 3200] - Brotli module added. [Bug 628898] See: gentoo#3200 Closes: https://bugs.gentoo.org/628898 Package-Manager: Portage-2.3.24, Repoman-2.3.6
nginScript is a subset of the JavaScript language that allows implementing location and variable handlers in http and stream.
http://nginx.org/en/docs/njs_about.html
http://nginx.org/en/docs/http/ngx_http_js_module.html
http://nginx.org/en/docs/stream/ngx_stream_js_module.html