New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-misc/zerotier: add 1.10.6 #32004
Conversation
Pull Request assignmentSubmitter: @parona-source net-misc/zerotier: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 884897 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2023-07-22 20:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Typos and give the debug use flag justification to exists even though it would just add preprocessor arguments when sso is disabled. |
Pull request CI reportReport generated at: 2023-07-24 02:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@thesamesam ill just ping here as well. no maintainer, but a more substantial bump. I get that debug use flag may be suspect when you arent building the optional rust bit. but having it makes it simpler overall. doing REQUIRED_USE="debug? ( sso )" is imo unnecessary. |
" | ||
DEPEND="${RDEPEND}" | ||
|
||
BDEPEPED=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope understood correctly that it was just the stray newline rather something else like spacing with the BDEPEND use or the rust dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, typo in the variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly a blind spot. Looked at everything around it and not at it. Thank you pointing that one, quite embarrassing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It happens :)
Pull request CI reportReport generated at: 2023-07-27 00:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/884897 Signed-off-by: Alfred Wingate <parona@protonmail.com>
Pull request CI reportReport generated at: 2023-07-27 09:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/884897
Ill note that Ive only tested amd64. And that SSO is a paid feature which I havent tested at runtime, it compiles correctly though. Its built as a static lib and then linked with zerotier-one binary.