Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/zerotier: add 1.10.6 #32004

Closed
wants to merge 1 commit into from

Conversation

parona-source
Copy link
Contributor

Closes: https://bugs.gentoo.org/884897

Ill note that Ive only tested amd64. And that SSO is a paid feature which I havent tested at runtime, it compiles correctly though. Its built as a static lib and then linked with zerotier-one binary.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @parona-source
Areas affected: ebuilds, profiles
Packages affected: net-misc/zerotier

net-misc/zerotier: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 884897


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 22, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-22 20:25 UTC
Newest commit scanned: cf33c28
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c740282d3f/output.html

@parona-source
Copy link
Contributor Author

Typos and give the debug use flag justification to exists even though it would just add preprocessor arguments when sso is disabled.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-24 02:40 UTC
Newest commit scanned: 46f7686
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3f01e54c1e/output.html

@parona-source
Copy link
Contributor Author

@thesamesam ill just ping here as well. no maintainer, but a more substantial bump.

I get that debug use flag may be suspect when you arent building the optional rust bit. but having it makes it simpler overall. doing REQUIRED_USE="debug? ( sso )" is imo unnecessary.

"
DEPEND="${RDEPEND}"

BDEPEPED="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope understood correctly that it was just the stray newline rather something else like spacing with the BDEPEND use or the rust dep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, typo in the variable name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly a blind spot. Looked at everything around it and not at it. Thank you pointing that one, quite embarrassing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens :)

net-misc/zerotier/zerotier-1.10.6.ebuild Outdated Show resolved Hide resolved
net-misc/zerotier/zerotier-1.10.6.ebuild Outdated Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-27 00:25 UTC
Newest commit scanned: f64041d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/82edf56027/output.html

Closes: https://bugs.gentoo.org/884897
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-27 09:05 UTC
Newest commit scanned: 06a23aa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f955219fe1/output.html

@parona-source parona-source deleted the zerotier branch August 10, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
4 participants