Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-power/phc-intel: new package #32063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kcning
Copy link
Contributor

@kcning kcning commented Jul 27, 2023

Add CPU frequency driver for Intel Pentium M, Core, Core 2 CPUs with undervolting feature.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @kcning
Areas affected: ebuilds
Packages affected: sys-power/phc-intel

sys-power/phc-intel: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 27, 2023
src_install() {
linux-mod-r1_src_install

echo 'blacklist acpi_cpufreq' > "${T}/${PN}".conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we were keeping the echo..

Suggested change
echo 'blacklist acpi_cpufreq' > "${T}/${PN}".conf
echo 'blacklist acpi_cpufreq' > "${T}/${PN}".conf || die

But we don't need echo here:

newins - ${PN}.conf <<-EOF
blacklist ...
EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you for the quick review!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-27 12:50 UTC
Newest commit scanned: 224ffed
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6f9c019447/output.html

@kcning kcning marked this pull request as draft July 27, 2023 16:16
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-27 17:35 UTC
Newest commit scanned: 2e75cf4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5e0c44c179/output.html

@kcning kcning force-pushed the phc-intel branch 3 times, most recently from 07c58c4 to dfca3f9 Compare July 27, 2023 21:43
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-27 22:25 UTC
Newest commit scanned: dfca3f9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ed306763b9/output.html

@kcning kcning marked this pull request as ready for review July 27, 2023 23:00
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-27 23:10 UTC
Newest commit scanned: 002098f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8dfdf5012a/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-28 00:30 UTC
Newest commit scanned: d13a8d2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c15abaa47b/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-29 08:10 UTC
Newest commit scanned: a556420
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/181dafa55d/output.html

Signed-off-by: Kai-Chun Ning <kaichun.ning@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-06 09:41 UTC
Newest commit scanned: 66fbfc6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fa9ff25926/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants