Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-rpg/baldurs-gate-ii-ee: new package, add 2.6.6.0.47292 #32092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

games-rpg/baldurs-gate-ii-ee: new package, add 2.6.6.0.47292 #32092

wants to merge 1 commit into from
+75 −0

Conversation

rayment
Copy link
Contributor

@rayment rayment commented Jul 29, 2023 •
edited

GOG copy of Baldur's Gate II: Enhanced Edition.

ebuild taken from games-rpg/baldurs-gate-ee and modified. Both games use the same engine and share assets. They also share version numbers so any updates to one ebuild should be generally applicable to the other for simplified maintenance.

I will be opening a pull request to proxy-maintain the other ebuild also. Edit: #32093

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @rayment
Areas affected: ebuilds
Packages affected: games-rpg/baldurs-gate-ii-ee

games-rpg/baldurs-gate-ii-ee: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 29, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-29 16:20 UTC
Newest commit scanned: 6365561
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/43965d4668/output.html

@rayment rayment mentioned this pull request Jul 29, 2023
Open
@thesamesam
Copy link
Member

For some reason, I have a connection with this game and Chewi in my head, so asking him to look. If I'm misremembering, apologies!

@thesamesam thesamesam requested a review from chewi August 17, 2023 06:20
chewi
chewi suggested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesamesam You remember wrong! Never played it and don't own it. Had a look anyway.

Is this definitely a 64-bit game? It smells like it could be 32-bit.

games-rpg/baldurs-gate-ii-ee/baldurs-gate-ii-ee-2.6.6.0.47292.ebuild Outdated Show resolved Hide resolved
@rayment
Copy link
Contributor Author

rayment commented Aug 17, 2023 •
edited

Is this definitely a 64-bit game? It smells like it could be 32-bit.

Unfortunately yes:

$ file BaldursGateII 
BaldursGateII: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=b747ca0952ffb99ac29b0e6cd8d9efcd31cb0b72, stripped

The original game would have been 32-bit but the enhanced edition (at least the most recent updates) is exclusive to 64-bit on Linux.

Edit: Actually I can confirm that 2.6 is definitely 64-bit only. Same goes for baldurs-gate-ee.

@rayment
games-rpg/baldurs-gate-ii-ee: new package, add 2.6.6.0.47292
85a7a4f 
Signed-off-by: Finn Rayment <finn@rayment.fr>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-17 07:16 UTC
Newest commit scanned: 85a7a4f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e04cf46c75/output.html

@rayment
Copy link
Contributor Author

rayment commented Oct 26, 2023

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewi chewi chewi requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@rayment @gentoo-bot @gentoo-repo-qa-bot @thesamesam @chewi