Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/portage: Migrate 9999 to use Meson #32098

Closed
wants to merge 3 commits into from
Closed

sys-apps/portage: Migrate 9999 to use Meson #32098

wants to merge 3 commits into from

Conversation

chewi
Copy link
Member

@chewi chewi commented Jul 29, 2023

@chewi
python-utils-r1.eclass: Remove old EAPI hack for exporting PYTHON
69495f2 
This eclass is EAPI 7+ now, so we can assume that BROOT is available.
This was broken anyway because it seems that Portage doesn't set BROOT
when it's empty.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@chewi
python-utils-r1.eclass: Fix shebangs using ${EPYTHON}, not ${PYTHON}
5373959 
${PYTHON} points to BROOT's Python because it's usually used for calling
Python during the build. This value will be wrong at runtime after
building cross-prefix.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@chewi chewi mentioned this pull request Jul 29, 2023
Closed
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @chewi
Areas affected: ebuilds, eclasses
Packages affected: sys-apps/portage

sys-apps/portage: @gentoo/portage

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jul 29, 2023
@thesamesam
Copy link
Member

Testing it now, thanks!

 * CMP: =sys-apps/portage-9999 with sys-apps/portage-9999/image
 *  FILES:-etc/logrotate.d/elog-save-summary
 *  FILES:-usr/lib/portage/pypy3/bashrc-functions.sh (-rwxr-xr-x root:root)
[...]

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-31 22:12 UTC
Newest commit scanned: cc3895d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/daadc80ce3/output.html

@chewi
sys-apps/portage: Migrate 9999 to use Meson
b150538 
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@chewi chewi changed the title WIP sys-apps/portage: Migrate 9999 to use Meson sys-apps/portage: Migrate 9999 to use Meson Aug 1, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-01 23:22 UTC
Newest commit scanned: b150538
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/edbd37edfe/output.html

@gentoo-bot gentoo-bot closed this in be37f97 Aug 2, 2023
@thesamesam
Copy link
Member

thesamesam commented Aug 2, 2023 •
edited

Thanks! So very appreciated.

Merged so we can test this out a bunch more. I've not included the eclass patches for now (not a comment on their contents, just that I didn't want to merge them myself, rather let you do it).

@thesamesam
Copy link
Member

Actually, I asked mgorny, and he said we should just get it in. So pushing that too. Thanks!

@chewi chewi deleted the portage-meson branch August 2, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionenwks ionenwks ionenwks left review comments

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@chewi @gentoo-bot @thesamesam @gentoo-repo-qa-bot @ionenwks