Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-misc/screen: Fix call to undeclared function chmod #32184

Closed
wants to merge 1 commit into from
Closed

app-misc/screen: Fix call to undeclared function chmod #32184

wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented Aug 5, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: app-misc/screen

app-misc/screen: @swegener, @gentoo/shell-tools

Linked bugs

Bugs linked: 894562

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 5, 2023
@listout
Copy link
Contributor Author

listout commented Aug 5, 2023 •
edited

Patch sent upstream at screen-devel@gnu.org

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-05 08:35 UTC
Newest commit scanned: 9959f81
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fe782c78d6/output.html

@listout
Copy link
Contributor Author

listout commented Aug 8, 2023

Patch merged upstream, https://git.savannah.gnu.org/cgit/screen.git/commit/?id=7f320d3a643ec95682a7213b7e991e27038d8a57

thesamesam
thesamesam reviewed Aug 8, 2023
View reviewed changes
app-misc/screen/files/screen-4.9.0-clang16-chmod.patch
@@ -0,0 +1,11 @@
Bug: https://bugs.gentoo.org/894562
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to upstream commit/submission in the patches always please (force push to update if it got merged after you made the PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@listout
app-misc/screen: Fix call to undeclared function chmod
b710c67 
Closes: https://bugs.gentoo.org/894562
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@gentoo-bot gentoo-bot closed this in 0e9f132 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @thesamesam