Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-gfx/gnofract4d: don't create dangling symlink in test phase #32212

Closed
wants to merge 2 commits into from

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Aug 7, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @cjmayo
Areas affected: ebuilds
Packages affected: media-gfx/gnofract4d

media-gfx/gnofract4d: @cjmayo, @gentoo/proxy-maint

Linked bugs

Bugs linked: 911809


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 7, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-07 18:40 UTC
Newest commit scanned: e2ba836
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4495e2b3cd/output.html

Signed-off-by: Chris Mayo <aklhfex@gmail.com>
@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 10, 2023

Add Python 3.12 on another commit. Tests pass.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-10 18:55 UTC
Newest commit scanned: 85aa130
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/74b719a769/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

=================================================== ERRORS ====================================================
_________________________ ERROR collecting fract4d/fract4d_new/tests/test_fract4dc.py _________________________
ImportError while importing test module '/var/tmp/portage/media-gfx/gnofract4d-4.3_p20230717/work/gnofract4d-47d2093e8f6399d1badfba0d1cb0f9867e90b326/fract4d/fract4d_new/tests/test_fract4dc.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.11/site-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
/usr/lib/python3.11/site-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
/usr/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
/usr/lib/python3.11/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
fract4d/fract4d_new/tests/test_fract4dc.py:5: in <module>
    from fract4d import fract4dc as Fract4dc

Also

 * The directory fract4d occludes package installed for python3.11.
 * The installed package includes additional files:
 * 
 *     fract4d/fract4dc.cpython-311-x86_64-linux-gnu.so
 * 
 * For more information on occluded packages, please see:
 * https://projects.gentoo.org/python/guide/test.html#importerrors-for-c-extensions

But runtime seems to work fine clicking here and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants