games-engines/scummvm-tools: Update to version 2.7.0 #32220
Conversation
Pull Request assignmentSubmitter: @alanswanson games-engines/scummvm-tools: @gentoo/games Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
alanswanson
force-pushed
the
scummvm-tools
branch
from
c195fbc
to
1529e3e
Compare
Pull request CI reportReport generated at: 2023-08-09 12:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
games-engines/scummvm-tools/files/scummvm-tools-2.7.0-binprefix.patch
Outdated
Show resolved
Hide resolved
| SLOT="0" | ||
| KEYWORDS="~amd64 ~ppc ~ppc64 ~x86" | ||
| IUSE="flac iconv mad png vorbis" | ||
| RESTRICT="test" # some tests require external files |
There was a problem hiding this comment.
Would be nice to either skip these tests or fetch these files.
There was a problem hiding this comment.
Inherited from existing ebuild. (The only change in the ebuild is the patches and the license which was from GPL2 to GPL3.)
| src_prepare() { | ||
| default | ||
|
|
||
| rm -r *.bat dists/win32 || die |
There was a problem hiding this comment.
Do you actually need to remove these, i.e. do they get installed or sth?
There was a problem hiding this comment.
Inherited from existing ebuild. (The only change in the ebuild is the patches and the license which was from GPL2 to GPL3.)
|
|
||
| # Not an autoconf script | ||
| ./configure \ | ||
| --disable-tremor \ |
There was a problem hiding this comment.
Why is it disabled unconditionally?
There was a problem hiding this comment.
Inherited from existing ebuild. (The only change in the ebuild is the patches and the license which was from GPL2 to GPL3.)
| --prefix="${EPREFIX}/usr" \ | ||
| $(use_enable flac) \ | ||
| $(use_enable iconv) \ | ||
| $(use_enable iconv freetype2) \ |
There was a problem hiding this comment.
That's a weird implication of charset conversion support.
There was a problem hiding this comment.
Inherited from existing ebuild. (The only change in the ebuild is the patches and the license which was from GPL2 to GPL3.)
alanswanson
force-pushed
the
scummvm-tools
branch
2 times, most recently
from
f4b7ecd
to
998050e
Compare
Pull request CI reportReport generated at: 2023-08-23 12:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
See also https://bugs.gentoo.org/906876 |
Prevent the annoying double "scummvm-tools-scummvm-tools*" bin renaming and change the wxGTK bin to "scummvm-tools-gui" to correspond to "scummvm-tools-cli". Closes: https://bugs.gentoo.org/906876 Signed-off-by: Alan Swanson <reiver@improbability.net>
alanswanson
force-pushed
the
scummvm-tools
branch
from
998050e
to
c0a728d
Compare
Pull request CI reportReport generated at: 2023-09-09 16:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
de3e041 |
|
Locally using following at src_install() to rename scummvm-tools to scummvm-tools-gui for disambiguation:
|
Prevent the annoying double "scummvm-tools-scummvm-tools*" bin renaming and change the wxGTK bin to "scummvm-tools-gui" to correspond to "scummvm-tools-cli".
I've not updated WX_GTK_VER but scummvm-tools should now be compatible with 3.2-gtk3 but not tested. Can update or remove as preferred by dev.