media-gfx/nomacs: add 3.17.2285 #32397
Conversation
Pull Request assignmentSubmitter: @listout media-gfx/nomacs: @gentoo/qt Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-08-20 19:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
force-pushed
the
nomacs-exiv-0.28-patch
branch
from
ecef991
to
92c894a
Compare
Pull request CI reportReport generated at: 2023-08-20 19:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| }; | ||
|
|
||
| +#if EXIV2_TEST_VERSION(0, 28, 0) | ||
| + Exiv2::Image::UniquePtr mExifImg; // TODO std::unique_ptr<Exiv2::Image> (and all other *::AutoPtr) |
There was a problem hiding this comment.
// TODO std::unique_ptr<Exiv2::Image> (and all other *::AutoPtr)
See also:
openstreetmap/merkaartor@1e20d2c
Using that would avoid #ifdefs and maybe result in an upstream-presentable PR for them to consider?
Alternatively, use auto: https://invent.kde.org/graphics/kphotoalbum/-/commit/82520a00bb8ca3f6400c7cc053066072e5055594
| DOCS=( src/changelog.txt ) | ||
|
|
||
| PATCHES=( | ||
| "${FILESDIR}"/${P}-exiv-0.28.0-build-fix.patch |
| # Fix bug #847112 | ||
| sed -e 's:QT_QMAKE_EXECUTABLE NAMES "qmake" "qmake-qt5" "qmake.exe":QT_QMAKE_EXECUTABLE NAMES "qmake" "qmake5" "qmake.exe":' \ | ||
| -i plugins/cmake/Utils.cmake || die |
There was a problem hiding this comment.
Please drop that ugly sed and simply set -DQT_QMAKE_EXECUTABLE=qmake5 in mycmakeargs instead. See also https://bugs.gentoo.org/847112
| sed -e "s:lib/nomacs-plugins:$(get_libdir)/nomacs-plugins:" \ | ||
| -i plugins/cmake/Utils.cmake || die |
There was a problem hiding this comment.
This can be replaced with upstream commit: nomacs/nomacs-plugins@e1d32cd
Of course not without adjusting paths.
Actually, that sed is obsolete with your version bump. And that's yet another example why sed is bad.
| sed -e "s:lib/nomacs-plugins:$(get_libdir)/nomacs-plugins:" \ | ||
| -i src/DkCore/DkPluginManager.cpp || die |
There was a problem hiding this comment.
This could be replaced with upstream commit: nomacs/nomacs@c8f6c32
Of course not without adjusting paths and dropping unrelated patch hunks (version bump, subproject)
Actually, that sed is obsolete with your version bump. And that's yet another example why sed is bad.
| DESCRIPTION="Qt-based image viewer" | ||
| HOMEPAGE="https://nomacs.org/" | ||
| SRC_URI="https://github.com/${PN}/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz | ||
| plugins? ( https://github.com/${PN}/${PN}-plugins/archive/$(ver_cut 1-2).tar.gz -> ${PLUGIN_PKG}.tar.gz )" |
There was a problem hiding this comment.
How is that supposed to work without nomacs-plugins-3.17 having been tagged? What exactly did you manifest there?
>>> Downloading 'https://github.com/nomacs/nomacs-plugins/archive/3.17.tar.gz'
--2023-09-03 11:51:29-- https://github.com/nomacs/nomacs-plugins/archive/3.17.tar.gz
Resolving github.com (github.com)... 140.82.121.3
Connecting to github.com (github.com)|140.82.121.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/nomacs/nomacs-plugins/tar.gz/3.17 [following]
--2023-09-03 11:51:29-- https://codeload.github.com/nomacs/nomacs-plugins/tar.gz/3.17
Resolving codeload.github.com (codeload.github.com)... 140.82.121.10
Connecting to codeload.github.com (codeload.github.com)|140.82.121.10|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-09-03 11:51:30 ERROR 404: Not Found.
!!! Couldn't download 'nomacs-plugins-3.17.tar.gz'. Aborting.
There was a problem hiding this comment.
Yeah, I couldn't find it/its not tagged
listout
force-pushed
the
nomacs-exiv-0.28-patch
branch
2 times, most recently
from
1f67f69
to
256db5d
Compare
Pull request CI reportReport generated at: 2023-09-03 12:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
force-pushed
the
nomacs-exiv-0.28-patch
branch
from
256db5d
to
0ae1234
Compare
Pull request CI reportReport generated at: 2023-09-03 14:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
I've made a PR upstream, waiting for replies from dev. cc: @a17r |
|
Try to use following instead: https://github.com/nomacs/nomacs/releases/tag/3.17.2285 https://github.com/novomesk/nomacs-plugins/releases/tag/3.17.2285 |
listout
force-pushed
the
nomacs-exiv-0.28-patch
branch
from
0ae1234
to
de949c7
Compare
listout
changed the title
Closes: https://bugs.gentoo.org/906488 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
listout
force-pushed
the
nomacs-exiv-0.28-patch
branch
from
de949c7
to
16a1c14
Compare
Pull request CI reportReport generated at: 2023-09-15 18:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@a17r Andreas, what is your opinion about the upgraded version? |
Closes: https://bugs.gentoo.org/906488