Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/sysdig: enforce -std=c++14 #32404

Closed
wants to merge 2 commits into from
Closed

dev-util/sysdig: enforce -std=c++14 #32404

wants to merge 2 commits into from

Conversation

hhoffstaette
Copy link
Contributor

@hhoffstaette hhoffstaette commented Aug 21, 2023 •
edited

Required after abseil ABI change.

@hhoffstaette
dev-util/sysdig: clean up old
dd984fa 
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
@hhoffstaette
dev-util/sysdig: enforce -std=c++14
df6056a 
Closes: https://bugs.gentoo.org/912774
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hhoffstaette
Areas affected: ebuilds
Packages affected: dev-util/sysdig

dev-util/sysdig: @hhoffstaette, @gentoo/proxy-maint

Linked bugs

Bugs linked: 912774

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 21, 2023
@hhoffstaette
Copy link
Contributor Author

hhoffstaette commented Aug 21, 2023 •
edited

Note that this will currently fail due to a packaging bug in (at least) grpc-1.57.0 with:

CMake Error at /usr/lib64/cmake/grpc/gRPCConfig.cmake:8 (find_dependency):
   Unknown CMake command "find_dependency".

This is because line 8 says find_dependency(Protobuf CONFIG), which should (?) be find_package instead. is an undefined macro that needs to be included.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-21 19:55 UTC
Newest commit scanned: df6056a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0dd638b7ae/output.html

@hhoffstaette hhoffstaette deleted the sysdig-c++14 branch August 22, 2023 06:17
MocioF pushed a commit to MocioF/gentoo that referenced this pull request Aug 23, 2023
@hhoffstaette @MocioF
dev-util/sysdig: enforce -std=c++14
2b27854 
Closes: https://bugs.gentoo.org/912774
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Closes: gentoo#32404
Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
3 participants
@hhoffstaette @gentoo-bot @gentoo-repo-qa-bot