games-simulation/openttd: install data to /usr/share/games #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see why there should be /usr/share/games in openttd instead of bumping games-misc/open* to new policy. You bumped these ebuilds to EAPI=6, so why you didn't done that with them? |
gentoo-repo-qa-bot
added
the
assigned
|
Pull Request assignment Areas affected: ebuilds games-misc/opengfx: @gentoo/games |
Gentoo-Bug: 600272 + some configure args cleanup
PS: I've cleaned up ./configure args a bit in games-simulation/openttd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gentoo/games
This resolves gentoo bug #600272
Note that according to recent QA policy it is allowed to install games data files to /usr/share/games and this is the case. Besides that IMHO it's better to keep using this dir than mess with some sophisticated version dependencies on games-misc/open{gfx,msx,sfx}.
Also correctly bumped games-misc/open{gfx,msx,sfx} to EAPI 6 to avoid recurring of this issue later.