KDE fixes #32487
KDE fixes #32487
Conversation
Signed-off-by: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
Signed-off-by: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
…conditional Signed-off-by: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
Signed-off-by: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
Signed-off-by: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
Pull Request assignmentSubmitter: @HanabishiRecca kde-frameworks/kdelibs4support: @gentoo/kde Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-08-28 15:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Thanks for this PR. I will likely pick your changes to kde overlay after all, to avoid revbumps for small fixes, since KDE Frameworks 5.110 and Plasma 5.27.8 are imminent/very near.. There is no need for you to move it over there yourself, unless you would like to. Original authorship and link to review discussion here will be retained of course.
| cmake_run_in src cmake_comment_add_subdirectory l10n | ||
| } | ||
|
|
||
| src_configure() { | ||
| local mycmakeargs=( | ||
| -DWITH_X11=$(usex X) | ||
| -DCMAKE_DISABLE_FIND_PACKAGE_NetworkManager=ON |
There was a problem hiding this comment.
Between #32474 (comment) and this change, did you come to a conclusion that this feature does not do anything (for us?) after all?
I'm just curious if there's more to it, otherwise will need to inquire myself.
There was a problem hiding this comment.
There is a standalone kded service generated if NM support is enabled. But I do not actually figured where it is being used.
Anyway, automagic dependencies are bad, so I think disabling it explicitly is fine for now. Introducing new use flags is more complicated question.
There was a problem hiding this comment.
There is a standalone kded service generated if NM support is enabled
kded_networkstatus is always being generated, just with or without NM backend support.
|
You are welcome. |
| dev-libs/libxml2 | ||
| dev-libs/libxslt |
There was a problem hiding this comment.
This also turns out not to be that easy. I traced it back to gentoo/kde@cd9341e and gentoo/kde@0e7d507, both of which still hold true today:
$ lddtree /usr/lib64/qt5/plugins/kf5/kio/kio_help.so
[...]
libKF5DocTools.so.5 => /usr/lib64/libKF5DocTools.so.5
libxslt.so.1 => /usr/lib64/libxslt.so.1
libxml2.so.2 => /usr/lib64/libxml2.so.2
liblzma.so.5 => /lib64/liblzma.so.5
libicuuc.so.73 => /usr/lib64/libicuuc.so.73
libicudata.so.73 => /usr/lib64/libicudata.so.73
libexslt.so.0 => /usr/lib64/libexslt.so.0
libgcrypt.so.20 => /usr/lib64/libgcrypt.so.20
libgpg-error.so.0 => /usr/lib64/libgpg-error.so.0
$ lddtree /usr/lib64/qt5/plugins/kf5/kio/kio_ghelp.so
[...]
libKF5DocTools.so.5 => /usr/lib64/libKF5DocTools.so.5
libxslt.so.1 => /usr/lib64/libxslt.so.1
libxml2.so.2 => /usr/lib64/libxml2.so.2
liblzma.so.5 => /lib64/liblzma.so.5
libicuuc.so.73 => /usr/lib64/libicuuc.so.73
libicudata.so.73 => /usr/lib64/libicudata.so.73
libexslt.so.0 => /usr/lib64/libexslt.so.0
libgcrypt.so.20 => /usr/lib64/libgcrypt.so.20
libgpg-error.so.0 => /usr/lib64/libgpg-error.so.0
However, we could rightfully assume that dev-libs/libxml2 and dev-libs/libxslt are being wrongfully unconditionally depended on here - and that's right after looking at https://invent.kde.org/frameworks/kio/-/blob/kf5/src/kioworkers/help/CMakeLists.txt. These deps had been there since the very beginning of that ebuild (gentoo/kde@7b5c719). It was correct at the time, but the deps became optional after https://invent.kde.org/frameworks/kio/-/commit/9861d5de30c0da09de8bd50407f154f1a6c1f171.
Looking at all that build system code at least spawned a minor upstream cleanup MR: https://invent.kde.org/frameworks/kio/-/merge_requests/1403
Unfortunately I can't retain git authorship anyway due to your use of a noreply-github-address, so it will be name-only attribution unless you change that. |
Thanks-to: Hanabishi Closes: gentoo/gentoo#32487 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Even if there is no linking with libnm.so, the service will be required at runtime if we build with this feature enabled. See also: gentoo/gentoo#32487 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Upstream translations organisation has changed since commit cd9341e. Moves handbook handling back into ecm.eclass and automatically fixes missing BDEPEND=kde-frameworks/kdoctools as well. See also: gentoo/gentoo#32487 Thanks-to: Hanabishi Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Follow-up to 3ba8e13, good to revisit these deps. Making features optional has consequences :) See also: gentoo/gentoo#32487 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
The rest fixes from #32474.