Add LLVM-libc #32500

alfredfo · 2023-08-28T21:07:38Z

No description provided.

gentoo-bot · 2023-08-28T21:08:04Z

Pull Request assignment

Submitter: @alfredfo
Areas affected: ebuilds
Packages affected: sys-apps/libc-hdrgen, sys-devel/gnuconfig, sys-libs/llvm-libc

sys-apps/libc-hdrgen: @gentoo/proxy-maint (new package)
sys-devel/gnuconfig: @gentoo/base-system
sys-libs/llvm-libc: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

sys-apps/libc-hdrgen/Manifest

mgorny

Also, please don't add old snapshots. They're going away anyway.

sys-apps/libc-hdrgen/libc-hdrgen-18.0.0.9999.ebuild

mgorny · 2023-08-29T03:44:21Z

sys-apps/libc-hdrgen/libc-hdrgen-18.0.0_pre20230825.ebuild

+	sys-devel/llvm:${LLVM_MAJOR}
+"
+
+LLVM_COMPONENTS=( llvm libc cmake )


Do you really have to build it via LLVM? That sounds like a major bad design.

Nope GCC works too, but I thought so at first because some code relies on Clang internals (apparently same for GCC). I'll remove this

Oh, do you mean llvm/ as root source directory? Yes, I am pretty sure. Also tells you to do that in docs.

mgorny · 2023-08-29T03:44:41Z

sys-devel/gnuconfig/files/gnuconfig-20230731-llvm-libc.patch

+From b0fbd0b9c6cc4453e37fd2253221473a34549437 Mon Sep 17 00:00:00 2001
+From: Alfred Persson Forsberg <cat@catcream.org>
+Date: Wed, 2 Aug 2023 02:37:38 +0200
+Subject: [PATCH] config.sub: add LLVM libc support


Is that an upstream patch?

Yeah, we really need to agree with the LLVM people on this and then send it upstream.

No, but I asked upstream about this and they said -llvm is fine for now. I'll ask again and try to get this upstreamed asap

Any update on this?

Sent a message on #libc now, also mentioned that every autotools based build is currently broken due to "unknown system". I guess I'll wait for a code owner to tell if '-llvm' is fine for fullbuild mode.

https://lists.gnu.org/archive/html/config-patches/2023-10/threads.html#00004 <- waiting for another response

Also merged llvm/llvm-project@d2f9268 and got code owner to agree on arch-vendor-kernel-llvm as triplet.

I guess we just wait for gnuconfig. @mgorny

alfredfo · 2023-08-29T08:51:08Z

@mgorny:

Also, please don't add old snapshots. They're going away anyway.

Aha okay, I just took the ones listed in llvm.org.eclass.

For new packages, should I only add the latest snapshot?

mgorny · 2023-08-29T09:49:17Z

Yes. Ideally start with getting 9999 right. I'm going to add a new snapshot today.

gentoo-repo-qa-bot · 2023-08-30T11:05:29Z

Pull request CI report

Report generated at: 2023-08-30 11:05 UTC
Newest commit scanned: dbbc095
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0ba425bf94/output.html

sys-apps/libc-hdrgen/libc-hdrgen-18.0.0.9999.ebuild

mgorny · 2023-09-18T15:58:11Z

sys-libs/llvm-libc/llvm-libc-18.0.0.9999.ebuild

+
+			# This is only used for targeting libc/ headers in the current llvm-project directory
+			# Crossdev has already handled the headers for us
+			-DCOMPILER_RT_BUILD_SCUDO_STANDALONE_WITH_LLVM_LIBC=$(is_crosspkg OFF ON)


How does that actually work?

https://github.com/llvm/llvm-project/blob/6af39d914c8377241b44f4e2fdd75b5ffff9c882/compiler-rt/lib/scudo/standalone/CMakeLists.txt#L174

Crossdev already installs the headers when emerging libc with USE=headers-only.

This option should probably be called -DCOMPILER_RT_BUILD_SCUDO_STANDALONE_WITH_LLVM_LIBC_HEADERS_IN_TREE instead, or something shorter.

gentoo-repo-qa-bot · 2023-09-19T03:36:21Z

Pull request CI report

Report generated at: 2023-09-19 03:36 UTC
Newest commit scanned: b2a4b87
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d9762e9a5f/output.html

mgorny · 2023-10-14T15:34:18Z

sys-apps/libc-hdrgen/libc-hdrgen-18.0.0.9999.ebuild

+		# CMake target to install libc-hdrgen only.
+		-DBUILD_SHARED_LIBS=OFF
+
+		-DLLVM_INCLUDE_TESTS=$(usex test)


What's the purpose of this if you aren't running tests?

Added just for completeness, I'll remove this for now

mgorny · 2023-10-14T15:35:00Z

sys-libs/llvm-libc/llvm-libc-18.0.0.9999.ebuild

+		)
+	fi
+
+	cmake_src_configure


CMake Error at CMakeLists.txt:245 (add_subdirectory): add_subdirectory given source "/tmp/portage/sys-libs/llvm-libc-18.0.0_pre20231013/work/runtimes/../llvm/utils/llvm-lit" which is not an existing directory.

After adding the directory:

CMake Error at /tmp/portage/sys-libs/llvm-libc-18.0.0_pre20231013/work/libc/cmake/modules/LLVMLibCLibraryRules.cmake:110 (add_library): No SOURCES given to target: libc_for_scudo_integration_test Call Stack (most recent call first): /tmp/portage/sys-libs/llvm-libc-18.0.0_pre20231013/work/libc/test/integration/scudo/CMakeLists.txt:12 (add_entrypoint_library)

Same as above, will take another look once the gnuconfig stuff has been worked out

Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>

Co-authored-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>

Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>

gentoo-repo-qa-bot · 2023-10-16T19:35:58Z

Pull request CI report

Report generated at: 2023-10-16 19:35 UTC
Newest commit scanned: 95d2878
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e9b1a28575/output.html

gentoo-repo-qa-bot · 2023-10-16T19:50:56Z

Pull request CI report

Report generated at: 2023-10-16 19:50 UTC
Newest commit scanned: 6f43b00
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/97bdd17962/output.html

gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 28, 2023

alfredfo force-pushed the gentoo-llvm-libc branch from e9695d2 to 9781fea Compare August 28, 2023 21:09

thesamesam reviewed Aug 28, 2023

View reviewed changes

sys-apps/libc-hdrgen/Manifest Outdated Show resolved Hide resolved

alfredfo force-pushed the gentoo-llvm-libc branch 3 times, most recently from 6c03444 to a38d8fc Compare August 28, 2023 21:39

mgorny reviewed Aug 29, 2023

View reviewed changes

alfredfo force-pushed the gentoo-llvm-libc branch 5 times, most recently from e953912 to dbbc095 Compare August 30, 2023 10:47

thesamesam requested a review from mgorny September 18, 2023 09:03

mgorny requested changes Sep 18, 2023

View reviewed changes

mgorny requested changes Oct 14, 2023

View reviewed changes

sys-libs/llvm-libc: new package, add 18.0.0.9999

82bb56f

Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>

alfredfo force-pushed the gentoo-llvm-libc branch from b2a4b87 to 95d2878 Compare October 16, 2023 19:20

alfredfo and others added 2 commits October 16, 2023 21:29

sys-apps/libc-hdrgen: new package, add 18.0.0.9999

8d3d8ca

Co-authored-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>

sys-devel/gnuconfig: Support LLVM-libc

6f43b00

Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>

alfredfo force-pushed the gentoo-llvm-libc branch from 95d2878 to 6f43b00 Compare October 16, 2023 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add LLVM-libc #32500

Add LLVM-libc #32500

alfredfo commented Aug 28, 2023

gentoo-bot commented Aug 28, 2023

mgorny left a comment

mgorny Aug 29, 2023

alfredfo Aug 29, 2023

alfredfo Aug 29, 2023

mgorny Aug 29, 2023

thesamesam Aug 29, 2023

alfredfo Aug 29, 2023

mgorny Oct 14, 2023

alfredfo Oct 16, 2023

alfredfo Oct 31, 2023 •

edited

alfredfo commented Aug 29, 2023 •

edited

mgorny commented Aug 29, 2023

gentoo-repo-qa-bot commented Aug 30, 2023

mgorny Sep 18, 2023

alfredfo Sep 19, 2023

gentoo-repo-qa-bot commented Sep 19, 2023

mgorny Oct 14, 2023

alfredfo Oct 16, 2023

mgorny Oct 14, 2023

alfredfo Oct 16, 2023

gentoo-repo-qa-bot commented Oct 16, 2023

gentoo-repo-qa-bot commented Oct 16, 2023

Add LLVM-libc #32500

Are you sure you want to change the base?

Add LLVM-libc #32500

Conversation

alfredfo commented Aug 28, 2023

gentoo-bot commented Aug 28, 2023

Pull Request assignment

Linked bugs

mgorny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alfredfo Oct 31, 2023 • edited

Choose a reason for hiding this comment

alfredfo commented Aug 29, 2023 • edited

mgorny commented Aug 29, 2023

gentoo-repo-qa-bot commented Aug 30, 2023

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Sep 19, 2023

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Oct 16, 2023

Pull request CI report

gentoo-repo-qa-bot commented Oct 16, 2023

Pull request CI report

alfredfo Oct 31, 2023 •

edited

alfredfo commented Aug 29, 2023 •

edited