sys-process/acct: initd implement checkpath, #603606 #3251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request assignment Areas affected: ebuilds sys-process/acct: @gentoo/base-system |
gentoo-repo-qa-bot
added
the
assigned
SoapGentoo
suggested changes
Dec 29, 2016
| touch "${ACCT_LOG}" | ||
| chmod 600 "${ACCT_LOG}" | ||
| fi | ||
| checkpath -f -m 600 "${ACCT_LOG}" |
There was a problem hiding this comment.
You're updating the init file, but how can you ensure that the updated file arrives on users' machines? You'll need to revbump the latest stable and unstable ebuilds.
There was a problem hiding this comment.
and leave the existing ebuilds as well I presume?
There was a problem hiding this comment.
yes, just latest of stable and unstable, use eshowkw for an easy overview (i.e. 6.5.5-r3 and 6.6.2)
There was a problem hiding this comment.
done, and rebased the changes to one commit
SoapGentoo
approved these changes
Jan 4, 2017
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentoo-Bug: https://bugs.gentoo.org/603606