x11-libs/fltk: add 1.3.8 #32543
x11-libs/fltk: add 1.3.8 #32543
Conversation
Pull Request assignmentSubmitter: @vowstar x11-libs/fltk: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 847607 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2023-09-01 02:00 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-09-01 02:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| --disable-localzlib \ | ||
| --docdir="${EPREFIX}/usr/share/doc/${PF}/html" \ | ||
| --enable-largefile \ | ||
| --enable-shared \ |
There was a problem hiding this comment.
This makes the static-libs use flag seem a bit redundant.
There was a problem hiding this comment.
Thank you very much for your review and suggestions.
There is actually no simple solution to the problem of fltk compiling with static-libs. The historical fltk ebuild method in ::gentoo is to compile static libraries and shared libraries at the same time, and then use static-libs according to the flag deletes the compiled static library.
The description of the option --enable-shared in the fltk documentation is:
Enable generation of shared libraries means that this option needs to be turned on by default, otherwise shared libraries will not be generated.
By default, fltk only generates static libraries and not shared libraries. This behavior is indeed troublesome.
For the above reasons, currently the --enable-shared option cannot be simply controlled by the static-libs use flag, because it will break net-misc/tigervnc-1.13.1-r3 (viewer ? x11- libs/fltk:1) sci-mathematics/octave-8.3.0 (fltk ? >=x11-libs/fltk-1.3:1[opengl,xft])
There was a problem hiding this comment.
Heh, of course it is :)
I'll add some comment to the ebuild, thanks for explaining!
There was a problem hiding this comment.
Although I don't see a dependency for static-libs on either octave or tigervnc. If nothing needs the static libs enabled on this package, maybe we can unconditionally always just remove them?
There was a problem hiding this comment.
Sorry, I just misunderstood.
I didn't find any package that really depends on this static-lib useflag in ::gentoo. Only executables in test/(from x11-libs/fltk test stage) are linking statically against libfltk.a. Therefore, we need to consider how to safely remove this static-lib useflag. I may need to change the link method in test/, or consider using test useflag to control it.
Closes: https://bugs.gentoo.org/847607 Signed-off-by: Huang Rui <vowstar@gmail.com>
Pull request CI reportReport generated at: 2023-10-06 14:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Also please sync 1.4.9999 live package or remove it if it doesn't serve any purpose anymore. |
Yes, I currently don’t know the intention of the previous maintainer of this live package, and I haven’t found any packages that must use this live package. |
bump fltk to 1.3.8
Closes: https://bugs.gentoo.org/847607