Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-wireless/iw: add rdepend on wireless-regdb #32562

Closed
wants to merge 1 commit into from

Conversation

negril
Copy link
Contributor

@negril negril commented Sep 2, 2023

iw can bring up a wireless device so it needs to depend on net-wireless/wireless-regdb.

Fix the compile flags, so they are actually fully honored.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @negril
Areas affected: ebuilds
Packages affected: net-wireless/iw

net-wireless/iw: @ZeroChaos-

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Sep 2, 2023
iw can bring up a wireless device so it needs to depend on
net-wireless/wireless-regdb.

Fix the compile flags, so they are actually fully honored.

Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
@ZeroChaos-
Copy link
Contributor

if isn't responsible for making connections to APs nor running Access Points. I don't believe the rdepend makes sense here.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-02 14:25 UTC
Newest commit scanned: 5184bd8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e1509a45d3/output.html

@negril
Copy link
Contributor Author

negril commented Sep 2, 2023

Did you have a look into iw help? It can start an AP, connect to one, scan and so on.

I think iw reg set should be a clear hint that you need wireless-regdom during runtime. ;)

@ZeroChaos-
Copy link
Contributor

Did you have a look into iw help? It can start an AP, connect to one, scan and so on.

I think iw reg set should be a clear hint that you need wireless-regdom during runtime. ;)

For the sake of argument, it's a not required for compiling or execution, it's an optional dep for one function. I have no desire to die on this hill though, so @thesamesam break the tie please.

@thesamesam
Copy link
Member

I don't really see the point in optimising in not having the dep, so let's add it in please.

@negril negril deleted the iw_remove_crda branch September 24, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants