Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sec-keys/openpgp-keys-wireshark: initial import #32575

Closed
wants to merge 6 commits into from
Closed

sec-keys/openpgp-keys-wireshark: initial import #32575

wants to merge 6 commits into from

Conversation

thesamesam
Copy link
Member

Signed-off-by: Sam James sam@gentoo.org

thesamesam added a commit to thesamesam/gentoo that referenced this pull request Sep 3, 2023
@thesamesam
net-analyzer/wireshark: add support for verify-sig
503c5ec 
Bug: https://bugs.gentoo.org/913394
Closes: gentoo#20401
Closes: gentoo#32575
Signed-off-by: Sam James <sam@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: ebuilds
Packages affected: app-crypt/openpgp-keys-wireshark, net-analyzer/wireshark

app-crypt/openpgp-keys-wireshark: @gentoo/proxy-maint (new package)
net-analyzer/wireshark: @thesamesam

Linked bugs

Bugs linked: 913394

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 3, 2023
@thesamesam
Copy link
Member Author

cc @mgorny

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-03 05:00 UTC
Newest commit scanned: 503c5ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/79158d0759/output.html

thesamesam added a commit to thesamesam/gentoo that referenced this pull request Sep 3, 2023
@thesamesam
net-analyzer/wireshark: add support for verify-sig
3e41e67 
Bug: https://bugs.gentoo.org/913394
Closes: gentoo#20401
Closes: gentoo#32575
Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam thesamesam changed the title app-crypt/openpgp-keys-wireshark: initial import sec-keys/openpgp-keys-wireshark: initial import Sep 3, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-03 05:45 UTC
Newest commit scanned: 3e41e67
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6bcf649738/output.html

mgorny pushed a commit to thesamesam/gentoo that referenced this pull request Sep 3, 2023
@thesamesam @mgorny
net-analyzer/wireshark: add support for verify-sig
2985aae 
Bug: https://bugs.gentoo.org/913394
Closes: gentoo#20401
Closes: gentoo#32575
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-03 13:55 UTC
Newest commit scanned: 2985aae
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2a11ba1e91/output.html

mgorny
mgorny reviewed Sep 3, 2023
View reviewed changes
eclass/verify-sig.eclass Outdated Show resolved Hide resolved
mgorny pushed a commit to thesamesam/gentoo that referenced this pull request Sep 3, 2023
@thesamesam @mgorny
net-analyzer/wireshark: add support for verify-sig
65db784 
Bug: https://bugs.gentoo.org/913394
Closes: gentoo#20401
Closes: gentoo#32575
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-03 15:25 UTC
Newest commit scanned: 0a6e05b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/873e985dc7/output.html

mgorny pushed a commit to thesamesam/gentoo that referenced this pull request Sep 3, 2023
@thesamesam @mgorny
net-analyzer/wireshark: add support for verify-sig
4ddfd1b 
Bug: https://bugs.gentoo.org/913394
Closes: gentoo#20401
Closes: gentoo#32575
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-03 17:25 UTC
Newest commit scanned: 0493a9d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/86cc5506df/output.html

ionenwks
ionenwks reviewed Sep 3, 2023
View reviewed changes
net-analyzer/wireshark/wireshark-9999.ebuild
Comment on lines +162 to +165
verify-sig_verify_signed_checksums \
"${DISTDIR}"/${P}-signatures.txt \
sha256 \
"${DISTDIR}"/${P}.tar.xz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cd / openssl-dsgt in this one? Not that it matters in live (yet), but just wondering if an oversight.

Beside that don't really have anything to say from a quick look. I'd probably have considered BASH_REMATCH in the eclass but utimately doesn't change much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, oversight. I've only modified the one ebuild I needed to test the eclass.

@mgorny
eclass/tests: Add initial tests for verify-sig
7e42c36 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
verify-sig.eclass: Support openssl dgst format checksums
6ece777 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
verify-sig.eclass: Fix handling multiple/duplicate signatures
3d8755c 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
verify-sig.eclass: Fix list formatting for VERIFY_SIG_METHOD
0d332d3 
Thanks to ulm for reporting.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@thesamesam @mgorny
sec-keys/openpgp-keys-wireshark: initial import
8401adf 
Bug: https://bugs.gentoo.org/913394
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@thesamesam @mgorny
net-analyzer/wireshark: add support for verify-sig
5d1d272 
Bug: https://bugs.gentoo.org/913394
Closes: gentoo#20401
Closes: gentoo#32575
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-08 10:35 UTC
Newest commit scanned: 5d1d272
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f0d5281921/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny left review comments

@ionenwks ionenwks ionenwks left review comments

@SoapGentoo SoapGentoo Awaiting requested review from SoapGentoo

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@thesamesam @gentoo-bot @gentoo-repo-qa-bot @mgorny @ionenwks