Fix libtool for clang darwin prefix #32731
Conversation
Bug: https://bugs.gentoo.org/758167 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Bug: https://bugs.gentoo.org/758167 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Bug: https://bugs.gentoo.org/758167 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Pull Request assignmentSubmitter: @DarthGandalf app-crypt/gpgme: @gentoo/base-system Linked bugsBugs linked: 758167 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
|
||
| elibtoolize | ||
| eautoreconf |
There was a problem hiding this comment.
Needs a comment for why it's autoreconf (someone might end up deleting it and replacing w/ elibtoolize or nothing if it looks like a leftover from a patch or similar).
| @@ -78,7 +78,7 @@ src_prepare() { | |||
| sed -i -e 's/__APPLE__/__NO_APPLE__/' lib/system/certs.c || die | |||
|
|
|||
| # Use sane .so versioning on FreeBSD. | |||
| elibtoolize | |||
| eautoreconf | |||
There was a problem hiding this comment.
Add a comment noting autoreconf is needed (elibtoolize not enough) for macos
| _LT_TAGVAR(archive_expsym_cmds, $1)="$SED 's|^|_|' < \$export_symbols > \$output_objdir/\$libname-symbols.expsym~\$CC -dynamiclib \$allow_undefined_flag -o \$lib \$libobjs \$deplibs \$compiler_flags -install_name \$rpath/\$soname \$verstring $_lt_dar_single_mod$_lt_dar_export_syms$_lt_dsymutil" | ||
| _LT_TAGVAR(module_expsym_cmds, $1)="$SED -e 's|^|_|' < \$export_symbols > \$output_objdir/\$libname-symbols.expsym~\$CC \$allow_undefined_flag -o \$lib -bundle \$libobjs \$deplibs \$compiler_flags$_lt_dar_export_syms$_lt_dsymutil" | ||
| - m4_if([$1], [CXX], | ||
| -[ if test yes != "$lt_cv_apple_cc_single_mod"; then |
There was a problem hiding this comment.
I don't suppose e.g. export lt_cv_apple_cc_single_mod=no in the ebuild does the same job?
Would really like to avoid a (doubly-)conditional patch.
There was a problem hiding this comment.
I should try the patch with gcc, perhaps it doesn't break it, then I can remove one condition. Same for the other condition, I didn't check whether it doesn't break normal linux.
I'll try lt_cv_apple_cc_single_mod first though
There was a problem hiding this comment.
lt_cv_apple_cc_single_mod set in profile works, thanks
Pull request CI reportReport generated at: 2023-09-11 23:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
No description provided.