media-libs/libfpx: Fix C++17 does not allow register storage class sp…

[listout]

…ecifier

and update EAPI 6 -> 8

Closes: https://bugs.gentoo.org/896246

[gentoo-bot]

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: media-libs/libfpx

media-libs/libfpx: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 896246

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-09-13 19:05 UTC
Newest commit scanned: 14a1330
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e3f847d105/output.html

[juippis]

What a patch. I think it's too large for our repo (can you run pkgcheck?)

Could you host it in your Github, make some "gentoo-distfiles" repo for example and upload it there. Out of curiousity I do wonder if you attach the patch on our bugzilla, and download it as an attachment, whether it works... :)

[orlitzky]

I reported this upstream in the hope that they will fix it there: ImageMagick/libfpx#5

[listout]

Sorry for late reply. But @juippis don't you think it would be better if a dev uploaded it to their developer space instead? I'll the bugzilla thing in the mean time. Referring #32041 (comment)

@orlitzky thanks! Upstream seems pretty dead to me (last commit being made 6 years ago)

[orlitzky]

Upstream actually fixed the issue! I think since it's being maintained by ImageMagick now, they are more likely "alive but uninterested." You could probably get PRs merged there though.

[listout]

Upstream actually fixed the issue! I think since it's being maintained by ImageMagick now, they are more likely "alive but uninterested." You could probably get PRs merged there though.

Yep, seems so with ImageMagick/libfpx@5f340b0 they fixed this issue. I guess now it's up to devs what to do with this one.

[juippis]

Sorry for late reply. But @juippis don't you think it would be better if a dev uploaded it to their developer space instead?

No I think it's better if the author hosted it to avoid delay in that regard and to be able to test it on their own. It'll get mirrored once pushed and then you have control to update it as required, without it passing through more hands.

Now it seems you can just SRC_URI the commit from upstream, or make a snapshot-version-release.