Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-text/sablotron: Fix clang16 build #32773

Closed
wants to merge 1 commit into from
Closed

app-text/sablotron: Fix clang16 build #32773

wants to merge 1 commit into from

Conversation

Schievel1
Copy link
Contributor

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Sep 14, 2023
Schievel1
Schievel1 commented Sep 14, 2023
View reviewed changes
app-text/sablotron/files/1.0.3-bind-with-lsupcxx.patch

dnl here we collect needed libraries
-OTHER_LIBS=
+OTHER_LIBS="-lsupc++ "
Copy link
Contributor Author

@Schievel1 Schievel1 Sep 14, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesamesam It this patch actually necessary? (And if it is, it this the correct place to add it?)
If I bind with CC=gcc CXX=gcc this fails because gcc does not automatically bind with lsupc++.
If I bind with CC=clang CXX=clang it fails as well.

But CC=clang CXX=clang++ works as well as CC=gcc CXX=g++

Then again, you wrote - Set CC=clang and CXX=clang in make.conf in your bashrc hook.

@Schievel1
app-text/sablotron: Fix clang16 build
be677cf 
Bug: https://bugs.gentoo.org/894710
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
@Schievel1 Schievel1 changed the title app-text/sablotron: Fix clang16 build app-text/sablotron: Fix clang16 build [please reassign] Sep 14, 2023
@gentoo-bot gentoo-bot changed the title app-text/sablotron: Fix clang16 build [please reassign] app-text/sablotron: Fix clang16 build Sep 14, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Schievel1
Areas affected: ebuilds
Packages affected: app-text/sablotron

app-text/sablotron: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 894710

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Sep 14, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-14 08:20 UTC
Newest commit scanned: 283e919
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a9bab21655/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-14 08:35 UTC
Newest commit scanned: be677cf
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/012d599661/output.html

@Schievel1
Copy link
Contributor Author

oh darn #32726

@Schievel1 Schievel1 closed this Sep 15, 2023
@listout
Copy link
Contributor

listout commented Sep 25, 2023

hehe, try to pick up other ones from https://bugs.gentoo.org/870412.

P.S. There are plenty :)

@Schievel1
Copy link
Contributor Author

hehe, try to pick up other ones from https://bugs.gentoo.org/870412.

P.S. There are plenty :)

I know I know, I’ve been doing a few already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@Schievel1 @gentoo-bot @gentoo-repo-qa-bot @listout