Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-puzzle/pauker: add 1.8-r3, update EAPI 6 -> 8 #32774

Closed
wants to merge 2 commits into from
Closed

games-puzzle/pauker: add 1.8-r3, update EAPI 6 -> 8 #32774

wants to merge 2 commits into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Sep 14, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: games-puzzle/pauker

games-puzzle/pauker: @gentoo/games

Linked bugs

Bugs linked: 831894, 914175

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 14, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-14 09:01 UTC
Newest commit scanned: 87a35bd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1789445bfa/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-14 09:16 UTC
Newest commit scanned: b7bc865
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6bc7a0bcba/output.html

arthurzam
arthurzam suggested changes Sep 14, 2023
View reviewed changes
games-puzzle/pauker/pauker-1.8-r3.ebuild Outdated
"${FILESDIR}/${PN}_bundledjars.patch"
"${FILESDIR}/pauker-1.8-r3-project.properties.patch"
)

S="${WORKDIR}"

src_prepare() {
default
find . -iname '*.jar' -delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing die:

Suggested change
find . -iname '*.jar' -delete
find . -iname '*.jar' -delete || die

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also done

games-puzzle/pauker/pauker-1.8-r3.ebuild Outdated
"${FILESDIR}/${PN}_bundledjars.patch"
"${FILESDIR}/pauker-1.8-r3-project.properties.patch"
)

S="${WORKDIR}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mvoe this declaration to be straight after SRC_URI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

games-puzzle/pauker/pauker-1.8-r3.ebuild Outdated Show resolved Hide resolved
games-puzzle/pauker/pauker-1.8-r3.ebuild Outdated
@@ -29,14 +31,17 @@ DEPEND="${COMMON_DEP}
app-arch/unzip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed in DEPEND?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to BDEPEND

@vaukai
games-puzzle/pauker: add 1.8-r3, update EAPI 6 -> 8
0998ff0 
Bug: https://bugs.gentoo.org/914175
Bug: https://bugs.gentoo.org/831894
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai
games-puzzle/pauker: drop 1.8-r2
88791fa 
Closes: https://bugs.gentoo.org/914175
Closes: https://bugs.gentoo.org/831894
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai deleted the pauker branch September 14, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurzam arthurzam arthurzam approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@vaukai @gentoo-bot @gentoo-repo-qa-bot @arthurzam