Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sci-astronomy/cpl: add 7.3.2, update EAPI 6 -> 8 #32799

Closed
wants to merge 2 commits into from
Closed

sci-astronomy/cpl: add 7.3.2, update EAPI 6 -> 8 #32799

wants to merge 2 commits into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Sep 15, 2023

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 15, 2023
@vaukai vaukai changed the title sci-astronomy/cpl: add 7.3.2 sci-astronomy/cpl: add 7.3.2 [please reassign] Sep 15, 2023
@gentoo-bot gentoo-bot changed the title sci-astronomy/cpl: add 7.3.2 [please reassign] sci-astronomy/cpl: add 7.3.2 Sep 15, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: sci-astronomy/cpl

sci-astronomy/cpl: @gentoo/sci-astronomy

Linked bugs

Bugs linked: 834577, 905683

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 15, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-15 13:00 UTC
Newest commit scanned: 2e95056
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5ea140c7ea/output.html

@vaukai vaukai changed the title sci-astronomy/cpl: add 7.3.2 sci-astronomy/cpl: add 7.3.2, update EAPI 6 -> 8 Sep 15, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-15 14:30 UTC
Newest commit scanned: e081263
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1c60f3f4f8/output.html

@arthurzam arthurzam self-requested a review September 17, 2023 14:28
arthurzam
arthurzam suggested changes Sep 17, 2023
View reviewed changes
Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: tests passed on my testing container

sci-astronomy/cpl/cpl-7.3.2.ebuild Outdated
Comment on lines 35 to 36
sed -e 's/\.a/\.so/g' \
-i m4/cpl.m4 || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from iwdevtools qa-sed output:

 * SED: the following did not cause any changes
 *     sed -e 's/\.a/\.so/g' -i m4/cpl.m4 || die;
 * no-op: -e s/\.a/\.so/g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removed it, pls go ahesd

@vaukai
sci-astronomy/cpl: add 7.3.2, update EAPI 6 -> 8
5b59556 
Bug: https://bugs.gentoo.org/834577
Bug: https://bugs.gentoo.org/905683
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai
sci-astronomy/cpl: drop 7.0-r1
26586ce 
Closes: https://bugs.gentoo.org/834577
Closes: https://bugs.gentoo.org/905683
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai deleted the cpl branch September 17, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurzam arthurzam arthurzam approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@vaukai @gentoo-bot @gentoo-repo-qa-bot @arthurzam