media-sound/supercollider: add new package #3280
Conversation
|
Pull Request assignment Areas affected: ebuilds media-sound/supercollider: @gentoo/proxy-maint (new package) |
gentoo-repo-qa-bot
added
new package
mrVanDalo
changed the title
| portaudio? ( media-libs/portaudio ) | ||
| jack? ( >=media-sound/jack2-1.9.10 ) | ||
| media-libs/alsa-lib | ||
| >=sys-libs/readline-5.0:* |
| >=sys-libs/readline-5.0:* | ||
| x11-libs/libXt | ||
| avahi? ( net-dns/avahi ) | ||
| fftw? ( >=sci-libs/fftw-3.0 ) |
| >=dev-qt/qtpositioning-5.6 | ||
| >=dev-qt/qtgui-5.6 | ||
| ) | ||
| sndfile? ( >=media-libs/libsndfile-1.0.16 ) |
There was a problem hiding this comment.
drop the version specifier, 1.0.16 is long gone
| ) | ||
| sndfile? ( >=media-libs/libsndfile-1.0.16 ) | ||
| system-boost? ( dev-libs/boost ) | ||
| system-yaml? ( dev-cpp/yaml-cpp ) |
There was a problem hiding this comment.
don't do this - get rid of the system-boost and system-yaml flags. Also, boost needs to be dev-libs/boost:=
|
|
||
| S="${WORKDIR}/SuperCollider-Source" | ||
|
|
||
| DOCS=( AUTHORS README_LINUX.md ) |
There was a problem hiding this comment.
get rid of these, covered by default set in einstalldocs
| -DSC_WII=$(usex wiimote) | ||
| ) | ||
| use jack && mycmakeargs+=( "AUDIOAPI=jack" ) | ||
| use portaudio && mycmakeargs+=( "AUDIOAPI=portaudio" ) |
There was a problem hiding this comment.
seeing that you have a ^^ REQUIRED_USE, just make this AUDIOAPI=$(usex jack jack portaudio)
|
|
||
| if [[ $(use debug) ]] | ||
| then | ||
| CMAKE_BUILD_TYPE="Debug" |
There was a problem hiding this comment.
in general, don't change CMAKE_BUILD_TYPE ever really
| # optimize for machine (will not run on other machines) | ||
| mycmakeargs+=( -DNATIVE=ON ) | ||
|
|
||
| if [[ $(use debug) ]] |
| einfo "Notice: SuperCollider is not very intuitive to get up and running." | ||
| einfo "The best course of action to make sure that the installation was" | ||
| einfo "successful and get you started with using SuperCollider is to take" | ||
| einfo "a look through /usr/share/doc/${PF}/README.gentoo" |
There was a problem hiding this comment.
einfo "a look through ${EROOT%/}/usr/share/doc/${PF}/README.gentoo"
There was a problem hiding this comment.
where is this README.gentoo ever generated? Missing readme.gentoo-r1.eclass perhaps?
| EAPI=6 | ||
|
|
||
| # are all of theses needed ? | ||
| inherit cmake-utils eutils multilib versionator |
There was a problem hiding this comment.
I don't see where you need eutils, multilib or versionator. You will probably need readme.gentoo-r1 though
|
@SoapGentoo Thanks for your detailed comments, will fix that tonight |
mrVanDalo
force-pushed
the
feature/supercollider
branch
from
43233bd
to
7063695
Compare
|
@SoapGentoo Sorry that it took me so long, but I had problems to build after forcing boost and yamlccp. Figuring that out took me a while. But I hope everything is fine now. |
mrVanDalo
force-pushed
the
feature/supercollider
branch
from
7063695
to
f080111
Compare
mrVanDalo
force-pushed
the
feature/supercollider
branch
from
f080111
to
5c77e14
Compare
|
@SoapGentoo ping. |
| cpu_flags_x86_sse cpu_flags_x86_sse2" | ||
|
|
||
| REQUIRED_USE=" | ||
| ide? ( qt5 ) |
There was a problem hiding this comment.
Is there good reason to have this? As far as I can see, USE=ide does not add another dependency, so why not drop that flag and conflict and let SC_IDE be controlled by qt5 as well?
There was a problem hiding this comment.
good point. will do it tomorrow in the train.
|
@mrVanDalo this one is on me, I slacked off a bit 😭 |
|
I see, thanks. No worries 😄 |
|
@mrVanDalo keep the contributions trickling in, Gentoo also thrives through user contributions 😃 |
|
sure I will 😄 there are some new ebuilds in the line. |
SuperCollider is a platform for audio synthesis and algorithmic composition, used by musicians, artists, and researchers working with sound. It is free and open source software available for Windows, Mac OS X, and Linux.
I created a Bug Ticket