app-containers/containers-{common,storage}: with stable & live of deps #32976
Conversation
Pull Request assignmentSubmitter: @rahilarious app-containers/containers-common: @gentoo/proxy-maint (new package) Linked bugsBugs linked: 914456, 904433, 907804, 907805 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
rahilarious
force-pushed
the
containers-common
branch
2 times, most recently
from
2a13e45
to
4170ac6
Compare
|
|
||
| SLOT="0" | ||
|
|
||
| DEPEND=" |
There was a problem hiding this comment.
BDEPEND (because we execute it during the build)
|
|
||
| EAPI=8 | ||
|
|
||
| DESCRIPTION="Common config files and docs for Containers eco-system" |
There was a problem hiding this comment.
Change the whitespace so it's like:
DESCRIPTION
HOMEPAGE
SRC_URI
LICENSE
SLOT
BDEPEND
...
src_prepare() {
}
...
This roughly matches skel.ebuild.
| [[ ${PV} == *9999* ]] | ||
| } | ||
|
|
||
| if is_live; then |
There was a problem hiding this comment.
I don't really see the benefit here, you could just put it above with SRC_URI (as suggested above).
Look at what other ebuilds do (e.g. ntpsec-9999)
| } | ||
|
|
||
| src_compile() { | ||
| emake docs || die |
There was a problem hiding this comment.
No need for || die with newer EAPIs for builtins like emake. Still needed for external commands which may fail.
| .PHONY: | ||
| EOF | ||
|
|
||
| eapply "${T}/fix-warnings.patch" || die |
| [[ -f docs/Makefile ]] || die | ||
| sed -i -e 's|/usr/local|/usr|g' docs/Makefile | ||
|
|
||
| cat <<"EOF" > "${T}/fix-warnings.patch" |
There was a problem hiding this comment.
Can't you put this in a proper patch in files/ and then add it to PATCHES in the ebuild?
| default | ||
|
|
||
| [[ -f docs/Makefile ]] || die | ||
| sed -i -e 's|/usr/local|/usr|g' docs/Makefile |
rahilarious
force-pushed
the
containers-common
branch
from
4170ac6
to
f542043
Compare
Pull request CI reportReport generated at: 2023-09-21 21:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
app-containers/containers-common depends on this Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
app-containers/containers-common depends on this Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
releasing 1.50.2 & live version in next commit Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
adding myself as maint + drop USE flags Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
Common configs & docs for Containers eco-system (i.e. podman buildah skopeo...) Go realm, executables are all in compiled, static, tidy in one binary but docs & configs...OMG all over the place. Spent whole day coding all these (such noob, I know), but was fun & fulfilling. Once this is merged the foundation of podman-stack is built, so will proceed to update frontend packages of eco-system. Closes: https://bugs.gentoo.org/907805 Closes: https://bugs.gentoo.org/904433 Closes: https://bugs.gentoo.org/914456 Closes: https://bugs.gentoo.org/907804 Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
rahilarious
force-pushed
the
containers-common
branch
from
f542043
to
c9faadc
Compare
Common configs & docs for Containers eco-system (i.e. podman buildah skopeo...)
Go realm, executables are all in compiled, static, tidy in one binary but docs & configs...OMG all over the place. Spent whole day coding all these (such noob, I know), but was fun & fulfilling. Once this is merged the foundation of podman-stack is built, so will proceed to update frontend packages of eco-system.
Closes: https://bugs.gentoo.org/907805
Closes: https://bugs.gentoo.org/904433
Closes: https://bugs.gentoo.org/914456
Closes: https://bugs.gentoo.org/907804