Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/sdl2-mixer: don't force stb_vorbis for OGG Vorbis music #33011

Closed
wants to merge 1 commit into from

Conversation

nE0sIghT
Copy link
Contributor

Neither the libvorbis nor the tremor are used for OGG Vorbis music regardless ebuild use flags because --enable-music-ogg-stb is used by default.
Let's disable stb_vorbis to use libvorbis or tremor for OGG Vorbis music.

Neither the libvorbis nor the tremor are used for OGG Vorbis music regardless
ebuild use flags because `--enable-music-ogg-stb` is used by default.
Let's disable stb_vorbis to use libvorbis or tremor for OGG Vorbis music.

Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @nE0sIghT
Areas affected: ebuilds
Packages affected: media-libs/sdl2-mixer

media-libs/sdl2-mixer: @gentoo/games

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Sep 23, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-23 18:00 UTC
Newest commit scanned: 84e092b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/766486c0ce/output.html

@chewi
Copy link
Member

chewi commented Sep 23, 2023

Good catch! We really shouldn't be using this regardless. I was about to push it, but I noticed that Opus is failing to be detected in the 32-bit multlib build for some reason, so I'll try to fix that first.

@chewi
Copy link
Member

chewi commented Sep 23, 2023

Cancel that, the problem seems to be with the Opus package itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants