New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-dialup/ppp: add missing openssl and pam configure options #33097
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wiktor Jaskulski <wiktor.jaskulski@adtran.com>
Pull Request assignmentSubmitter: @wikjas net-dialup/ppp: @gentoo/base-system Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2023-09-28 07:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need to review the configure logic before merging this. I seem to recall that passing a path disables the pkg-config logic, which is undesirable.
Co-authored-by: Mike Gilbert <floppymaster@gmail.com> Signed-off-by: wikjas <wiktor.jaskulski@adtran.com>
Pull request CI reportReport generated at: 2023-09-29 09:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
…et-dialup/ppp-2.5.0-r2 Signed-off-by: Wiktor Jaskulski <wiktor.jaskulski@adtran.com>
This change should be applied for >=net-dialup/ppp-2.5.0-r2 |
Pull request CI reportReport generated at: 2023-09-29 10:20 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
For net-dialup/ppp there are missing options in econf array. Because openssl and pam are DEPENDS, their headers should be searched in ${SYSROOT}. This can be done with proper configure options. Below important fragments of diff between config.log files (cross compilation for arm example).
--- config.log.orig 2023-09-27 16:13:35.870667419 +0200
+++ config.log 2023-09-27 16:09:38.784557342 +0200
-configure:14206: checking for openssl/ssl.h in /usr/local/ssl
-configure:14221: result: no
-configure:14206: checking for openssl/ssl.h in /usr/lib/ssl
-configure:14221: result: no
-configure:14206: checking for openssl/ssl.h in /usr/ssl
-configure:14221: result: no
-configure:14206: checking for openssl/ssl.h in /usr/pkg
-configure:14221: result: no
-configure:14206: checking for openssl/ssl.h in /usr/local
-configure:14221: result: no
-configure:14206: checking for openssl/ssl.h in /usr
+configure:14206: checking for openssl/ssl.h in /usr/armv7a-hardfloat-linux-gnueabi/usr/
configure:14215: result: yes
-configure:14936: checking for pam_appl.h in /usr/local
-configure:14945: result: no
-configure:14936: checking for pam_appl.h in /usr/lib
+configure:14936: checking for pam_appl.h in /usr/armv7a-hardfloat-linux-gnueabi
configure:14945: result: no
-configure:14936: checking for pam_appl.h in /usr
-configure:14941: result: yes