sys-kernel/genkernel: updated 9999 to reflect recent changes #33102
Conversation
Pull Request assignmentSubmitter: @timkenhan sys-kernel/genkernel: @gentoo/genkernel Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
timkenhan
force-pushed
the
genkernel-modular-features
branch
from
5420a37
to
a8470e7
Compare
Pull request CI reportReport generated at: 2023-09-28 15:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
|
||
| GK_FEATURES="" # prepare genkernel feature list | ||
|
|
||
| if use b2sum ; then GK_FEATURES="${GK_FEATURES}b2sum " ; fi |
There was a problem hiding this comment.
Ebuilds are written in Bash so you're free to use arrays (and should!)
| @@ -103,7 +103,7 @@ HOMEPAGE="https://wiki.gentoo.org/wiki/Genkernel https://gitweb.gentoo.org/proj/ | |||
| LICENSE="GPL-2" | |||
| SLOT="0" | |||
| RESTRICT="" | |||
| IUSE="ibm +firmware" | |||
| IUSE="ibm +firmware +doc -btrfs -plymouth -b2sum -bcache -dmraid -e2fsprogs -iscsi -luks -lvm -mdadm -multipath -ssh -strace -unionfs -xfsprogs -zfs" | |||
There was a problem hiding this comment.
-x is (mostly) the same as x in IUSE, see https://devmanual.gentoo.org/general-concepts/use-flags/index.html#iuse-defaults.
| plymouth? ( sys-boot/plymouth ) | ||
| doc? ( app-text/asciidoc )" | ||
| # iscsi ? ( net-libs/libiscsi ) | ||
| # dmraid ? ( sys-fs/ ) |
There was a problem hiding this comment.
I'd leave these out for now / remove it from the final commit, even fi it's what we're adding towards.
(Also, the syntax is x? ( ... ), not x ? ( ... )).
But for now, we can make the distfiles conditionally downloaded depending on which features are enabled, right?
There was a problem hiding this comment.
Thanks! I'll change it accordingly!
timkenhan
force-pushed
the
genkernel-modular-features
branch
from
a8470e7
to
b6eaa0a
Compare
Pull request CI reportReport generated at: 2023-10-02 06:57 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
timkenhan
force-pushed
the
genkernel-modular-features
branch
from
b6eaa0a
to
a1f0a97
Compare
Pull request CI reportReport generated at: 2023-10-03 06:21 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@thesamesam any other changes i should make? |
Pull request CI reportReport generated at: 2023-10-04 05:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-10-10 04:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
timkenhan
force-pushed
the
genkernel-modular-features
branch
from
ed2986a
to
cc2bafb
Compare
Pull request CI reportReport generated at: 2023-10-11 13:51 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
timkenhan
force-pushed
the
genkernel-modular-features
branch
from
cc2bafb
to
c3e560c
Compare
Pull request CI reportReport generated at: 2023-10-16 11:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Timothy Kenno Handojo
timkenhan
force-pushed
the
genkernel-modular-features
branch
from
c3e560c
to
f5c1679
Compare
Pull request CI reportReport generated at: 2023-10-21 05:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Ref: gentoo/genkernel#52