Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-libs/libesmtp: Fix call to undeclared function strlcpy #33149

Closed
wants to merge 1 commit into from
Closed

net-libs/libesmtp: Fix call to undeclared function strlcpy #33149

wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented Oct 1, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: net-libs/libesmtp

net-libs/libesmtp: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 896056

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 1, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-01 17:31 UTC
Newest commit scanned: 77a7613
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/935bbff064/output.html

mm1ke
mm1ke reviewed Oct 6, 2023
View reviewed changes
net-libs/libesmtp/libesmtp-1.1.0-r2.ebuild Outdated
KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~loong ~ppc ~ppc64 ~riscv ~s390 ~sparc ~x86 ~amd64-linux ~x86-linux"
fi

LICENSE="LGPL-2.1 GPL-2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be: LICENSE="LGPL-2.1+ GPL-2+"

@mm1ke
Copy link
Contributor

mm1ke commented Oct 6, 2023

Also, with 1.1.0 libesmtp has a build flag for a ntlm plugin. (see: libesmtp/libESMTP@1c304e7)
However, i guess this is out of scope of this PR

@listout
Copy link
Contributor Author

listout commented Oct 6, 2023

Also, with 1.1.0 libesmtp has a build flag for a ntlm plugin. (see: libesmtp/libESMTP@1c304e7) However, i guess this is out of scope of this PR

Agree, someone familiar with the libesmtp code base is the best person to handle that. But more than happy to help.

@listout
net-libs/libesmtp: Fix call to undeclared function strlcpy
9ecf351 
And update EAPI 7 -> 8

Closes: https://bugs.gentoo.org/896056
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-06 17:31 UTC
Newest commit scanned: 9ecf351
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a267fb18b3/output.html

@gentoo-bot gentoo-bot closed this in 6c55e3c Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm1ke mm1ke mm1ke left review comments

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @mm1ke @juippis