Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-emulation/mupen64plus-video-rice: C++17 does not allow register #33204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

listout
Copy link
Contributor

@listout listout commented Oct 5, 2023

And update EAPI 7 -> 8

Closes: https://bugs.gentoo.org/895976

And update EAPI 7 -> 8

Closes: https://bugs.gentoo.org/895976
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: games-emulation/mupen64plus-video-rice

games-emulation/mupen64plus-video-rice: @mgorny

Linked bugs

Bugs linked: 895976


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 5, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-05 16:06 UTC
Newest commit scanned: 87bb64d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/92c1e55242/output.html

DEPEND="${RDEPEND}"
BDEPEND="virtual/pkgconfig"

S=${WORKDIR}/${MY_P}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be below SRC_URI, also i suggest: S="${WORKDIR}/${MY_P}"


EAPI=8

MY_P=${PN}-src-${PV}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there shouldn't be any variables before ìnherit` unless it's required for eclasses? Could be wrong here though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants