Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail-filter/rspamd: add 3.7.4, drop 3.5-r1, sync live #33277

Closed
wants to merge 3 commits into from
Closed

mail-filter/rspamd: add 3.7.4, drop 3.5-r1, sync live #33277

wants to merge 3 commits into from

Conversation

arkamar
Copy link
Member

@arkamar arkamar commented Oct 10, 2023 •
edited

See the commit message for 3.7.4.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Oct 10, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-10 12:16 UTC
Newest commit scanned: ec7f573
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/01153be667/output.html

inode64 added a commit to inode64/inode64-overlay that referenced this pull request Oct 26, 2023
@inode64
Update rspamd 3.7.1 form pull gentoo/gentoo#33277
f6987c5
@arkamar arkamar force-pushed the rspamd/update branch 2 times, most recently from 8152c82 to d1c4909 Compare October 29, 2023 17:14
@arkamar
Copy link
Member Author

arkamar commented Oct 29, 2023

FP replacing 3.7.1 with recently released 3.7.3.

@arkamar arkamar changed the title mail-filter/rspamd: add 3.7.1, drop 3.5-r1, sync live mail-filter/rspamd: add 3.7.3, drop 3.5-r1, sync live [please reassign] Oct 29, 2023
@gentoo-bot gentoo-bot changed the title mail-filter/rspamd: add 3.7.3, drop 3.5-r1, sync live [please reassign] mail-filter/rspamd: add 3.7.3, drop 3.5-r1, sync live Oct 29, 2023
@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Oct 29, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-29 17:25 UTC
Newest commit scanned: d1c4909
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/83493aac1a/output.html

@arkamar
mail-filter/rspamd: add 3.7.4
65501ac 
Unneeded dependencies detected by qa-vdb:
- sys-apps/file  - Upstream does not use it since version 2.0, see [1].
- dev-libs/libev - Upstream bundles this library since version 2.0,
		   see [2]. It contains few incompatible changes [3-5],
		   which make unbundling currently unfeasible.

dev-libs/libfmt and dev-libs/xxhash are DEPEND only, detected by qa-vdb.
Upstream uses them both in inline mode, see [6] and [7], respecitvely.

Upstream bundles backward-cpp [8] since version 3.7.1. It was necessary
to disable its auto-detection property. The last release was in 2021, so
I decided to keep it bundled for now.

This version also contains the fix for GCC 14, see bug 916438.

[1] rspamd/rspamd@56e236e
[2] rspamd/rspamd@5376c8a
[3] rspamd/rspamd@7c4eb70
[4] rspamd/rspamd@b3713de
[5] rspamd/rspamd@0194245
[6] https://github.com/rspamd/rspamd/blob/3.7.3/CMakeLists.txt#L264
[7] https://github.com/rspamd/rspamd/blob/3.7.3/src/libcryptobox/cryptobox.c#L30-L31
[8] https://github.com/bombela/backward-cpp

Closes: https://bugs.gentoo.org/916438
Closes: https://bugs.gentoo.org/916488
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@arkamar
mail-filter/rspamd: sync live
67d2a5e 
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@arkamar
mail-filter/rspamd: drop 3.5-r1
dd23c3d 
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@arkamar arkamar changed the title mail-filter/rspamd: add 3.7.3, drop 3.5-r1, sync live mail-filter/rspamd: add 3.7.4, drop 3.5-r1, sync live [please reassign] Nov 14, 2023
@gentoo-bot gentoo-bot changed the title mail-filter/rspamd: add 3.7.4, drop 3.5-r1, sync live [please reassign] mail-filter/rspamd: add 3.7.4, drop 3.5-r1, sync live Nov 14, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @arkamar
Areas affected: ebuilds
Packages affected: mail-filter/rspamd

mail-filter/rspamd: @arkamar, @gentoo/proxy-maint

Linked bugs

Bugs linked: 916488, 916438

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@arkamar
Copy link
Member Author

arkamar commented Nov 14, 2023

FP with recent release 3.7.4.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 14, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-14 16:01 UTC
Newest commit scanned: dd23c3d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/af37451320/output.html

@arkamar arkamar marked this pull request as draft November 15, 2023 14:51
@arkamar
Copy link
Member Author

arkamar commented Nov 15, 2023 •
edited

3.7.4 may be affected by rspamd/rspamd#4703

@arkamar
Copy link
Member Author

arkamar commented Nov 15, 2023 •
edited

I will reset this PR to a previous state. I wasn't able to reproduce it.

@arkamar arkamar marked this pull request as ready for review November 15, 2023 16:59
@vstakhov
Copy link

I think this particular bug is related solely to how another library is built. RHEL does not provide fasttext library for old versions and for non-amd64 architectures (it's very weird, I know). So I guess it is a distro specific issue completely.

@arkamar
Copy link
Member Author

arkamar commented Nov 15, 2023

@vstakhov thank you for clarification.

@arkamar arkamar deleted the rspamd/update branch November 29, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@arkamar @gentoo-repo-qa-bot @gentoo-bot @vstakhov