net-irc/quassel: update EAPI 7 -> 8, drop unused dev-qt/qtscript #33334
Conversation
Pull Request assignmentSubmitter: @a17r net-irc/quassel: @thesamesam Linked bugsBugs linked: 877309 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-10-14 20:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
net-irc/quassel/quassel-9999.ebuild
Outdated
| DEPEND+=" test? ( dev-cpp/gtest dev-qt/qttest )" | ||
| ) | ||
| " | ||
| DEPEND="${RDEPEND} |
There was a problem hiding this comment.
Nit:
| DEPEND="${RDEPEND} | |
| DEPEND=" | |
| ${RDEPEND} |
There was a problem hiding this comment.
still following kde proj guidelines for style there and I think it is nicer for *DEPEND vars to be on the same line, but okay. ;)
| @@ -0,0 +1,54 @@ | |||
| From 020c163421691fa37330826df92ac0a248721290 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Please add a link to the PR (quassel/quassel#615) at the top of the file
- dev-qt/qtscript dependency was dropped in upstream commit
42d328e94a3bed8e6b0a32e7a234281e6d184325
- add missing dev-qt/qttest:5 slot dep
- drop unused IUSE debug
- style fixes (one dep per line, unnecessary DEPEND append)
- fix broken elog link (use https)
- missing || die
- use optfeature
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Bug: https://bugs.gentoo.org/877309 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
See also: quassel/quassel#615 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
42d328e94a3bed8e6b0a32e7a234281e6d184325