Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-p2p/qbittorrent: bump to 4.5.5, add OpenRC service #33365

Closed
wants to merge 3 commits into from
Closed

net-p2p/qbittorrent: bump to 4.5.5, add OpenRC service #33365

wants to merge 3 commits into from

Conversation

xbt573
Copy link
Contributor

@xbt573 xbt573 commented Oct 16, 2023 •
edited

List of changes:

  • Bumped qBittorrent to 4.5.5
  • Added systemd flag (installs systemd service when webui is enabled)
  • Added OpenRC service (/etc/init.d/qbittorrent, /etc/conf.d/qbittorrent), installs when -systemd webui is set

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Oct 16, 2023
@xbt573
acct-group/qbittorrent: new package, add 0
ec0ae9e 
Signed-off-by: Alexey Lunev <cheembox573@gmail.com>
@xbt573 xbt573 changed the title net-p2p/qbittorrent: bump to 4.5.5, add OpenRC service net-p2p/qbittorrent: bump to 4.5.5, add OpenRC service [please reassign] Oct 16, 2023
@gentoo-bot gentoo-bot changed the title net-p2p/qbittorrent: bump to 4.5.5, add OpenRC service [please reassign] net-p2p/qbittorrent: bump to 4.5.5, add OpenRC service Oct 16, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xbt573
Areas affected: ebuilds
Packages affected: acct-group/qbittorrent, acct-user/qbittorrent, net-p2p/qbittorrent

acct-group/qbittorrent: @gentoo/proxy-maint (new package)
acct-user/qbittorrent: @gentoo/proxy-maint (new package)
net-p2p/qbittorrent: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Oct 16, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-16 21:11 UTC
Newest commit scanned: 674cb2c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5ad937a756/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-16 21:26 UTC
Newest commit scanned: ced2d9a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/30715a565a/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-17 11:20 UTC
Newest commit scanned: 54a1b16
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a5e332a906/output.html

dlan17
dlan17 reviewed Oct 19, 2023
View reviewed changes
acct-group/qbittorrent/qbittorrent-0.ebuild
inherit acct-group

DESCRIPTION="Group for the system-wide net-p2p/qbittorrent server"
ACCT_GROUP_ID=534
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you get this ID? I believe you should request it via gentoo api repo

please have a look at following repo, run "bin/used_free_uidgids.sh" to check available IDs, and send a PR
https://github.com/gentoo/api-gentoo-org

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentoo/api-gentoo-org#632

dlan17
dlan17 reviewed Oct 19, 2023
View reviewed changes
net-p2p/qbittorrent/qbittorrent-4.5.5.ebuild Outdated
)

webui? (
>=acct-group/qbittorrent-0
>=acct-user/qbittorrent-0
)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you want to guard this under USE="webui", personally I'd have acct-* unconditionally without IUSE control, since it's quite trivial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-19 05:40 UTC
Newest commit scanned: 4a22613
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/07c58900ca/output.html

dlan17
dlan17 reviewed Oct 19, 2023
View reviewed changes
net-p2p/qbittorrent/qbittorrent-4.5.5.ebuild Outdated
if use webui && ! use systemd; then
newconfd "${FILESDIR}/${PN}.confd" ${PN}
newinitd "${FILESDIR}/${PN}.initd" ${PN}
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please install openrc intrd/confd files unconditionally, see explanation here
https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dlan17
Copy link
Contributor

dlan17 commented Oct 19, 2023

so, according to the changes of metadata.xml, you would like to take over the maintenance of this package in the future, for the long term? which means the bugs in b.g.o will be assigned to you, and we will also open a proxy maintainer bug for you, take a look at https://bugs.gentoo.org/915468 for example

Flowdalic
Flowdalic reviewed Oct 19, 2023
View reviewed changes
acct-user/qbittorrent/qbittorrent-0.ebuild Outdated
DESCRIPTION="User for the system wide net-p2p/qbittorrent server"
ACCT_USER_ID=534
ACCT_USER_HOME=/var/lib/qbittorrent
ACCT_USER_HOME_PERMS=0770
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really have to be 770, and not 750?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to 750 in last commits

Flowdalic
Flowdalic reviewed Oct 19, 2023
View reviewed changes
net-p2p/qbittorrent/qbittorrent-9999.ebuild Outdated
)"
)
>=acct-group/qbittorrent-0
>=acct-user/qbittorrent-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a little bit overly verbose. A single line containing act-user/qbittorrent would be sufficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xbt573
Copy link
Contributor Author

xbt573 commented Oct 19, 2023

so, according to the changes of metadata.xml, you would like to take over the maintenance of this package in the future, for the long term? which means the bugs in b.g.o will be assigned to you, and we will also open a proxy maintainer bug for you, take a look at https://bugs.gentoo.org/915468 for example

yes, i would like to take over the maintenance of qbittorrent

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-19 11:16 UTC
Newest commit scanned: 0d534e6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b70a7361a0/output.html

@Flowdalic
Copy link
Member

Feel free to squash the commits accordingly

@xbt573
acct-user/qbittorrent: new package, add 0
d5bd665 
Signed-off-by: Alexey Lunev <cheembox573@gmail.com>
@xbt573
net-p2p/qbittorrent: bump to 4.5.5, add openrc service & qt6
1555357 
Signed-off-by: Alexey Lunev <cheembox573@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-19 12:26 UTC
Newest commit scanned: 1555357
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8d437d1dc1/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowdalic Flowdalic Flowdalic left review comments

@dlan17 dlan17 dlan17 left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. new package The PR is adding a new package. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@xbt573 @gentoo-bot @gentoo-repo-qa-bot @dlan17 @Flowdalic