Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtscript-removal++ #33447

Merged
merged 11 commits into from Oct 21, 2023
Merged

qtscript-removal++ #33447

merged 11 commits into from Oct 21, 2023

Conversation

a17r
Copy link
Member

@a17r a17r commented Oct 21, 2023

Maintainers, please ACK.

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 21, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-21 19:56 UTC
Newest commit scanned: 9f08731
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b3f33872e6/output.html

@a17r a17r changed the title qtscript-removal++ qtscript-removal++ [please reassign] Oct 21, 2023
@a17r a17r added the no assignee limit Ignore assignee limit, and ping as many maintainers as it takes. label Oct 21, 2023
@gentoo-bot gentoo-bot changed the title qtscript-removal++ [please reassign] qtscript-removal++ Oct 21, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @a17r
Areas affected: ebuilds
Packages affected: app-editors/texworks, app-misc/qlcplus, app-office/texmaker, dev-db/sqlitestudio, media-gfx/meshlab...

app-editors/texworks: @gentoo/proxy-maint (maintainer needed)
app-misc/qlcplus: @kripton, @gentoo/proxy-maint
app-office/texmaker: @gentoo/tex
dev-db/sqlitestudio: @gentoo/proxy-maint (maintainer needed)
media-gfx/meshlab: @gentoo/3dprint, @Amynka
media-video/smplayer: @gentoo/qt, @gentoo/video

Linked bugs

Bugs linked: 893952, 915780, 915785, 915786, 915788, 915789, 808691, 763837


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 21, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-10-21 20:56 UTC
Newest commit scanned: aade06a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/24619e8261/output.html

@a17r a17r added the noci Skip CI for this pull request label Oct 21, 2023
- respin existing hunspell/singleapp patch for 5.1 rather than use sed
- add missing dev-qt/qtcore:5= slot op for private header use
- dev-qt/qtscript:5 was replaced by dev-qt/qtdeclarative:5 in >=5.1.0
- dev-qt/qtwebengine:5[widgets] is still required
- dev-qt/qtconcurrent:5 is not linked against

Bug: https://bugs.gentoo.org/915780
See also: gentoo#22948
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
- add missing dev-qt/qttest:5 dependency
- dev-qt/qtscript:5 was replaced by dev-qt/qtdeclarative:5
- fix upstream's "optional" (really not) Qt5Script in build system

Bug: https://bugs.gentoo.org/915780
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
- add missing pkg_postrm() phase

Bug: https://bugs.gentoo.org/915785
See also: gentoo#26074
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Bug: https://bugs.gentoo.org/915786
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Closes: https://bugs.gentoo.org/915786
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
CMAKE_BUILD_TYPE=Release was ignored by eclass so setting it was a no-op.

Bug: https://bugs.gentoo.org/915788
Bug: https://bugs.gentoo.org/763837
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Closes: https://bugs.gentoo.org/915788
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Fix HOMEPAGE.

dev-qt/qtscript:5 was unused since 21.08.0.

dev-qt/qtdbus:5 was unconditional since commit
a3988c2.

Bug: https://bugs.gentoo.org/915789
Bug: https://bugs.gentoo.org/808691
Closes: https://bugs.gentoo.org/893952
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@gentoo-bot gentoo-bot merged commit cf23582 into gentoo:master Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no assignee limit Ignore assignee limit, and ping as many maintainers as it takes. noci Skip CI for this pull request
Projects
None yet
3 participants