media-libs/audiofile: Fix Clang compilation failure #33614
Conversation
Due to upstream not having a push since 2016 (and it's not quite last rite'd yet), this fixes the Clang compilation failure from deprecated functions by adding `-stdlib=libstdc++` to CXXFLAGS. Closes: https://bugs.gentoo.org/914349 Signed-off-by: Christopher Fore <csfore@posteo.net>
Pull Request assignmentSubmitter: @csfore media-libs/audiofile: @gentoo/sound Linked bugsBugs linked: 914349 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-10-31 19:01 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| @@ -32,6 +32,10 @@ src_prepare() { | |||
| } | |||
|
|
|||
| multilib_src_configure() { | |||
| # Bug 914349 | |||
| if tc-is-clang; then | |||
| append-flags "-stdlib=libstdc++" | |||
There was a problem hiding this comment.
We can't do this - it breaks ABI if it was previously built with libcxx.
There was a problem hiding this comment.
Ah I see, what do you recommend I look at instead?
There was a problem hiding this comment.
Maybe it should be forced to build with gcc like how btop does?
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-process/btop/btop-1.2.13.ebuild#n20
Due to upstream not having a push since 2016 (and it's not quite last rite'd yet), this fixes the Clang compilation failure from deprecated functions by adding
-stdlib=libstdc++to CXXFLAGS.I made sure to run the test suite and it seems to report:
but it seems to behave correctly outside of tests, not sure how to proceed if that is a blocker so I'm highlighting it to make sure I haven't missed something.
Closes: https://bugs.gentoo.org/914349