Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-im/synapse: restrict <dev-python/twisted-23.8.1 and 1.96.0 security bump #33616

Closed
wants to merge 2 commits into from
Closed

net-im/synapse: restrict <dev-python/twisted-23.8.1 and 1.96.0 security bump #33616

wants to merge 2 commits into from

Conversation

arkamar
Copy link
Member

@arkamar arkamar commented Nov 1, 2023 •
edited

  • It was necessary to restrict <dev-python/twisted-23.8.1 to make all tests pass
  • security bump to 1.96.0

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @arkamar
Areas affected: ebuilds
Packages affected: net-im/synapse

net-im/synapse: @arkamar, @gentoo/proxy-maint

Linked bugs

Bugs linked: 916609

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues labels Nov 1, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-01 09:01 UTC
Newest commit scanned: 3b71e5f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/929b59de22/output.html

thesamesam
thesamesam reviewed Nov 1, 2023
View reviewed changes
net-im/synapse/synapse-1.95.0-r1.ebuild Outdated
@@ -121,7 +122,7 @@ RDEPEND="
dev-python/signedjson[${PYTHON_USEDEP}]
dev-python/sortedcontainers[${PYTHON_USEDEP}]
dev-python/treq[${PYTHON_USEDEP}]
dev-python/twisted[${PYTHON_USEDEP}]
<=dev-python/twisted-23.8.0[${PYTHON_USEDEP}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful - this will exclude -rN which likely isn't intentional.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks! I have changed it to <dev-python/twisted-23.8.1 in recent FP.

@arkamar arkamar force-pushed the synapse branch 2 times, most recently from d6c9696 to 04cfc59 Compare November 1, 2023 09:26
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-01 09:46 UTC
Newest commit scanned: 04cfc59
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6c613fad0d/output.html

@arkamar arkamar changed the title net-im/synapse: restrict <=dev-python/twisted-23.8.0 and 1.95.1 security bump net-im/synapse: restrict <dev-python/twisted-23.8.1 and 1.95.1 security bump Nov 1, 2023
@arkamar
net-im/synapse: restrict <dev-python/twisted-23.8.1
1dab624 
Some tests are known to fail with >twisted-23.8, see [1]

[1] matrix-org/synapse#16528

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@arkamar
net-im/synapse: add 1.96.0
2f1dbf2 
Bug: https://bugs.gentoo.org/916609
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@arkamar arkamar changed the title net-im/synapse: restrict <dev-python/twisted-23.8.1 and 1.95.1 security bump net-im/synapse: restrict <dev-python/twisted-23.8.1 and 1.96.0 security bump Nov 17, 2023
@arkamar
Copy link
Member Author

arkamar commented Nov 17, 2023

FP with rebased branch, 1.95.1 was replaced with newly relased 1.96.0.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-17 09:31 UTC
Newest commit scanned: 2f1dbf2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0f4b0d59c7/output.html

@arkamar arkamar deleted the synapse branch November 29, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam Awaiting requested review from thesamesam

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@arkamar @gentoo-bot @gentoo-repo-qa-bot @thesamesam