Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/mimetic: Fix C++17 does not allow register storage class #33666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dev-libs/mimetic: Fix C++17 does not allow register storage class #33666

wants to merge 1 commit into from
+141 −0

Conversation

listout
Copy link
Contributor

@listout listout commented Nov 3, 2023

and other build error related to >=C++11.
Also update EAPI 7 -> 8.

Closes: https://bugs.gentoo.org/895056

@listout
dev-libs/mimetic: Fix C++17 does not allow register storage class
9bec78e 
and other build error related to >=C++11.
Also update EAPI 7 -> 8.

Closes: https://bugs.gentoo.org/895056
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@listout
Copy link
Contributor Author

listout commented Nov 3, 2023

Needs review from devs (with better CPP knowledge than me) on the unary_function removal part. The idea for the fix came from the stackoverflow answer: https://stackoverflow.com/a/76316745

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: dev-libs/mimetic

dev-libs/mimetic: @jktjkt, @kensington

Linked bugs

Bugs linked: 895056

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 3, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-03 15:06 UTC
Newest commit scanned: 9bec78e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e7e23bbaba/output.html

mm1ke
mm1ke reviewed Nov 6, 2023
View reviewed changes
dev-libs/mimetic/mimetic-0.9.8-r1.ebuild

DESCRIPTION="C++ MIME library designed to be easy to use and integrate, fast and efficient"
HOMEPAGE="http://www.codesink.org/mimetic_mime_library.html"
SRC_URI="http://www.codesink.org/download/${P}.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http -> https. Since the HOMEPAGE supports https i guess the download should work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm1ke mm1ke mm1ke left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @mm1ke