distutils-r1/python-utils-r1.eclass: Support EPYTEST_XDIST #33667
Conversation
Pull Request assignmentSubmitter: @mgorny dev-python/numpy: @gentoo/sci, @gentoo/python Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-11-03 19:42 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
This is great! Especially ${EPYTEST_JOBS} will help on devboxes such as catbus.sparc, where we have a huge amount of cores, that work well with make or ninja, but with pytest-xdist this job count doesn't work well (each core is very weak) - so now I can set it up with normal amount of jobs.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Add an `EPYTEST_XDIST` variable that can be used to enable running the test suite in parallel via the dev-python/pytest-xdist plugin. This also includes user-facing `EPYTEST_JOBS` to control the job count independently of `MAKEOPTS`. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Make `distutils_enable_tests pytest` automatically add the `dev-python/pytest-xdist` dependency if `EPYTEST_XDIST` is set. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Pull request CI reportReport generated at: 2023-11-04 06:17 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| >=dev-python/pytz-2019.3[${PYTHON_USEDEP}] | ||
| ) | ||
| " | ||
|
|
||
| EPYTEST_XDIST=1 |
There was a problem hiding this comment.
I'd prefer it if we always kept eclass vars above inherit, but w/e.
| if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then | ||
| test_deps+=" ${test_pkg}[${PYTHON_USEDEP}]" | ||
| test_deps+=" ${test_pkgs//'${PYTHON_USEDEP}'/${PYTHON_USEDEP}}" |
There was a problem hiding this comment.
I think this looks a bit grim but if the metadata looks ok, good enough.
Add an
EPYTEST_XDISTcontrol variable that:epytestenable xdist with the usual set of parameters (provided that we're actually doing >1 job).distutils_enable_tests pytestadddev-python/pytext-xdistdep.Also add
EPYTEST_JOBSto control jobs independently ofMAKEOPTS.I suppose when this lands, we'd use a pkgcheck check for
EPYTEST_XDISTbeing declared afterd_e_tcall.