Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-lang/luajit: Fix cross-compiling from 64-bit to 32-bit #33670

Closed
wants to merge 2 commits into from

Conversation

chewi
Copy link
Member

@chewi chewi commented Nov 4, 2023

This will only work with a multilib build host toolchain, so probably just amd64 and ppc64, but it's better than nothing.

Multilib profiles specify an explicit target rather than just -m32 in LDFLAGS, but this should still do the right thing, and there's probably no way to query the build profile.

Closes: https://bugs.gentoo.org/627332

@chewi chewi self-assigned this Nov 4, 2023
@chewi chewi requested a review from thesamesam November 4, 2023 16:23
@chewi
Copy link
Member Author

chewi commented Nov 4, 2023

CC @williamh. P.S. I can properly assign you as a review if you join the Gentoo organisation.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-04 16:36 UTC
Newest commit scanned: 61940ae
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2f5ff22e2a/output.html

dev-lang/luajit/luajit-2.1.0_beta3_p20220613.ebuild Outdated Show resolved Hide resolved
dev-lang/luajit/luajit-2.1.0_beta3_p20220613.ebuild Outdated Show resolved Hide resolved
tc-get-ptr-size for CHOST and tc-get-build-ptr-size for CBUILD.

Closes: https://bugs.gentoo.org/328401
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
This will only work with a multilib build host toolchain, so probably
just amd64 and ppc64, but it's better than nothing.

Multilib profiles specify an explicit target rather than just -m32 in
LDFLAGS, but this should still do the right thing, and there's probably
no way to query the build profile.

Closes: https://bugs.gentoo.org/627332
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-04 23:59 UTC
Newest commit scanned: d02b252
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c881b5e233/output.html

@chewi chewi requested a review from thesamesam November 5, 2023 23:15
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Thanks!

@chewi
Copy link
Member Author

chewi commented Nov 20, 2023

This was merged in 6fab286.

@chewi chewi closed this Nov 20, 2023
@chewi chewi deleted the luajit-cross branch November 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants