Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-editor/diakonos-0.9.8.ebuild version bump and EAPI bump #33737

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

app-editor/diakonos-0.9.8.ebuild version bump and EAPI bump #33737

wants to merge 1 commit into from
+38 −55

Conversation

mipseb
Copy link
Contributor

@mipseb mipseb commented Nov 9, 2023

diakonos version and EAPI bump

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 9, 2023
@mipseb mipseb force-pushed the dia-bump branch 2 times, most recently from 7affa87 to e0db2a2 Compare November 9, 2023 09:53
@mipseb mipseb changed the title app-editor/diakonos-0.9.8.ebuild version bump and EAPI bump app-editor/diakonos-0.9.8.ebuild version bump and EAPI bump [please reassign] Nov 9, 2023
@gentoo-bot gentoo-bot changed the title app-editor/diakonos-0.9.8.ebuild version bump and EAPI bump [please reassign] app-editor/diakonos-0.9.8.ebuild version bump and EAPI bump Nov 9, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mipseb
Areas affected: ebuilds
Packages affected: app-editors/diakonos, app-emulation/faudio

app-editors/diakonos: @gentoo/proxy-maint (maintainer needed)
app-emulation/faudio: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. labels Nov 9, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-09 10:16 UTC
Newest commit scanned: e0db2a2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0101bb6d51/output.html

scardracs
scardracs reviewed Nov 11, 2023
View reviewed changes
app-editors/diakonos/diakonos-0.9.8.ebuild

DESCRIPTION="A Linux editor for the masses"
HOMEPAGE="https://git.sr.ht/~pistos/diakonos"
SRC_URI="https://git.sr.ht/~pistos/diakonos/archive/${206b112ac989457b8e51b95c272c380f4bf9221bPV}.tar.gz -> ${P}.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit you posted seems does not exist. The right way to do so is to use COMMIT="abcxyz"
SRC_URI="https://https://git.sr.ht/~pistos/diakonos/archive/${COMMIT}.tar.gz -> ${P}.tar.gz"
That's because at 90% of times you need ${COMMIT} for ${S} too. On top of that I don't see any 0.9.8 releases around the site you have posted... did you assume it will be released as it? I'd suggest to use diakonos-0.9.7_p20230706 instead, if you mind using using commit 8493d9a91d936b22eaded08fbbea849db2e96921

@mipseb mipseb force-pushed the dia-bump branch 2 times, most recently from eafb76f to f977b86 Compare November 15, 2023 06:56
@mipseb
app-editor/diakonos-0.9.7.ebuild version bump to 0.9.8 and EAPI bump …
35bd0d1 
…to version 8

Signed-off-by: Germ Mipseb <germtoo@outlook.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-15 08:47 UTC
Newest commit scanned: 35bd0d1
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/5c9dfc9e60/output.html#app-editors/diakonos
https://qa-reports.gentoo.org/output/gentoo-ci/5c9dfc9e60/output.html#app-emulation/86Box

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5c9dfc9e60/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scardracs scardracs scardracs left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@mipseb @gentoo-bot @gentoo-repo-qa-bot @scardracs