app-crypt/veracrypt: revbump with added patch to fix #605018 #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-repo-qa-bot
added
the
assigned
|
As it stands, this PR depends on #3379 being merged |
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
mgorny
requested changes
May 21, 2017
| @@ -45,6 +45,15 @@ PATCHES=( | |||
| "${FILESDIR}/${P}-remove-packaging-from-makefile.patch" | |||
| ) | |||
|
|
|||
| src_prepare() { | |||
| default | |||
| WX_BASENAME=$( ${EROOT}usr/bin/wx-config --basename ) | |||
There was a problem hiding this comment.
${EROOT} is not available in src_* phases. Just rely on PATH working correctly, and call the executable by name.
| src_prepare() { | ||
| default | ||
| WX_BASENAME=$( ${EROOT}usr/bin/wx-config --basename ) | ||
| if [[ ${WX_BASENAME} == "wx_baseu" ]] ; then |
There was a problem hiding this comment.
Conditional patching is strongly discouraged. Can't you get the patch to be correct unconditionally? Then you should submit it upstream.
|
#3379 has been rejected due to no activity, and this is being closed for the same reason. Feel free to reopen if you are still interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.