Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-p2p/qbittorrent: add 4.6.1 #33978

Closed
wants to merge 1 commit into from
Closed

net-p2p/qbittorrent: add 4.6.1 #33978

wants to merge 1 commit into from

Conversation

xbt573
Copy link
Contributor

@xbt573 xbt573 commented Nov 25, 2023

@xbt573
net-p2p/qbittorrent: add 4.6.1
bafe3fe 
Closes: https://bugs.gentoo.org/916447
Signed-off-by: Alexey Lunev <cheembox573@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xbt573
Areas affected: ebuilds
Packages affected: net-p2p/qbittorrent

net-p2p/qbittorrent: @xbt573, @gentoo/proxy-maint

Linked bugs

Bugs linked: 916447

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 25, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-25 12:46 UTC
Newest commit scanned: bafe3fe
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/55e6609589/output.html

@xbt573 xbt573 mentioned this pull request Nov 25, 2023
Closed
juippis
juippis approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had some comments about #33594 but forgot to post them. Can't really remember what I wanted to say, I guess having qt6 use flag separated from the gui looks weird to me. But as long as it works. I would personally probably simplify it a bit and not duplicate these qt6? !qt6 calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@xbt573 @gentoo-bot @gentoo-repo-qa-bot @juippis