app-accessibility/brltty: correctly handle USE=python when building for non-default python #34029
Conversation
Although --disable-python-bindings was used in the main build, to defer building them for the python_foreach, the original use_enable was never removed. So the python bindings if enabled at all, would always build twice or more: once for python3, and once for each USE-enabled impl. The python3 version might not actually work due to dependencies, so the build might fail. If it did work by *coincidence*, it would be for whatever the default python-exec is, which may not be what is in PYTHON_TARGETS. Bug: https://bugs.gentoo.org/905695 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
This does not use distutils-r1, so we need to manually add this dependency in order for the upstream Makefile to go drive a non-pep517 build all by itself. Closes: https://bugs.gentoo.org/905695 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Pull Request assignmentSubmitter: @eli-schwartz app-accessibility/brltty: @gentoo/accessibility Linked bugsBugs linked: 905695 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
The Autostart/Udev directory executes tcl scripts as part of installation, unrelated to tcl bindings. It is therefore required unconditionally at build time. Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Pull request CI reportReport generated at: 2023-11-28 19:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-11-28 19:56 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
It still does not install for me. Ever since commit 5b7979e, you run make install in Autostart/Udev, which only works when USE=tcl.
EDIT: fixed that too, I think.