dev-util/meson: backport patch to stop hiding vala compiler warnings #34141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially bad because it makes these packages disappear entirely from QA checks for, say, Modern C. Although it's only a matter of adding more warnings, and doesn't really affect the resulting packages, we need this live in order to do proper QA. Bug: https://bugs.gentoo.org/870412 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
|
@thesamesam big yikes :D |
Pull Request assignmentSubmitter: @eli-schwartz dev-util/meson: @gentoo/base-system, @eli-schwartz Linked bugsBugs linked: 870412 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2023-12-06 05:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
martinpitt
added a commit
to martinpitt/umockdev
that referenced
this pull request
Mar 1, 2024
meson 1.4 stopped hiding valac's warnings [1], which fails compilation due to our `-Werror=` settings. There's not much that we can do at this point, so stop making them non-fatal. This reverts the `gentoo-hacks` option from commit 539af0b. Turns out that this wasn't a compiler change in Gentoo after all, but that Gentoo backported [2] that meson change at that time. Many thanks to Dominique Leuenberger @DimStar77 for tracking down the root cause! Fixes #228 [1] mesonbuild/meson@5f659af870011e [2] gentoo/gentoo#34141
martinpitt
added a commit
to martinpitt/umockdev
that referenced
this pull request
Mar 1, 2024
meson 1.4 stopped hiding valac's warnings [1], which fails compilation due to our `-Werror=` settings. There's not much that we can do at this point, so stop making them non-fatal. This reverts the `gentoo-hacks` option from commit 539af0b. Turns out that this wasn't a compiler change in Gentoo after all, but that Gentoo backported [2] that meson change at that time. Many thanks to Dominique Leuenberger @DimStar77 for tracking down the root cause! Fixes #228 [1] mesonbuild/meson@5f659af870011e [2] gentoo/gentoo#34141
martinpitt
added a commit
to martinpitt/umockdev
that referenced
this pull request
Mar 1, 2024
meson 1.4 stopped hiding valac's warnings [1], which fails compilation due to our `-Werror=` settings. There's not much that we can do at this point, so stop making them non-fatal. This reverts the `gentoo-hacks` option from commit 539af0b. Turns out that this wasn't a compiler change in Gentoo after all, but that Gentoo backported [2] that meson change at that time. Many thanks to Dominique Leuenberger @DimStar77 for tracking down the root cause! Fixes #228 [1] mesonbuild/meson@5f659af870011e [2] gentoo/gentoo#34141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially bad because it makes these packages disappear entirely from QA checks for, say, Modern C. Although it's only a matter of adding more warnings, and doesn't really affect the resulting packages, we need this live in order to do proper QA.
See: mesonbuild/meson#12597
Bug: https://bugs.gentoo.org/870412