Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-crypt/moolticute: add 1.03.0, fix compile on GCC 14 #34225

Closed
wants to merge 1 commit into from
Closed

app-crypt/moolticute: add 1.03.0, fix compile on GCC 14 #34225

wants to merge 1 commit into from

Conversation

csfore
Copy link
Contributor

@csfore csfore commented Dec 10, 2023

The patch attached fixes compilation on GCC 14 and has been sent upstream.

Upstream PR: mooltipass/moolticute#1204

Closes: https://bugs.gentoo.org/916994

@csfore
app-crypt/moolticute: add 1.03.0, fix compile on GCC 14
601f0fa 
The patch attached fixes compilation on GCC 14 and has been sent
upstream.

Upstream PR: mooltipass/moolticute#1204

Closes: https://bugs.gentoo.org/916994
Signed-off-by: Christopher Fore <csfore@posteo.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @csfore
Areas affected: ebuilds
Packages affected: app-crypt/moolticute

app-crypt/moolticute: @nemunaire, @gentoo/proxy-maint

Linked bugs

Bugs linked: 916994

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 10, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-10 22:28 UTC
Newest commit scanned: 601f0fa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bbb0aed72e/output.html

thesamesam
thesamesam reviewed Dec 12, 2023
View reviewed changes
app-crypt/moolticute/files/moolticute-1.03.0-fix-return-type.patch
@@ -0,0 +1,13 @@
diff --git a/src/MPDeviceBleImpl.cpp b/src/MPDeviceBleImpl.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always add references to the top of patches, like upstream links + gentoo bugs.

See https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#patch-descriptions. I'll do that for you here, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I'll remember that for next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@csfore @gentoo-bot @gentoo-repo-qa-bot @thesamesam