Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-i18n/fcitx-chinese-addons: new package, add 5.1.2 #34237

Closed
wants to merge 6 commits into from
Closed

app-i18n/fcitx-chinese-addons: new package, add 5.1.2 #34237

wants to merge 6 commits into from

Conversation

liangyongxiang
Copy link
Contributor

@liangyongxiang liangyongxiang commented Dec 11, 2023 •
edited

  • app-i18n/libime: new package, add 1.1.3
  • app-i18n/fcitx-lua: new package, add 5.0.11
  • profiles/base: Default to lua-5.4 for app-i18n/fcitx-lua
  • app-i18n/fcitx-chinese-addons: new package, add 5.1.2
  • app-i18n/fcitx-table-extra: add 5.1.0
  • app-i18n/fcitx-table-other: new package, add 5.1.0

app-i18n/fcitx-chinese-addons is a Chinese language add-on for fcitx5.
For fcitx-chinese-addons, app-i18n/libime is its dependency, app-i18n/fcitx-lua is its optional dependency.
And fcitx-table-extra and fcitx-table-other provide more optional tables.

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 11, 2023
@liangyongxiang liangyongxiang changed the title aapp-i18n/fcitx-chinese-addons: new package, add 5.1.2 app-i18n/fcitx-chinese-addons: new package, add 5.1.2 Dec 11, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-11 17:03 UTC
Newest commit scanned: e1548f9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9a0b428a9d/output.html

@liangyongxiang liangyongxiang changed the title app-i18n/fcitx-chinese-addons: new package, add 5.1.2 [please reassign]app-i18n/fcitx-chinese-addons: new package, add 5.1.2 Dec 12, 2023
@gentoo-bot gentoo-bot changed the title [please reassign]app-i18n/fcitx-chinese-addons: new package, add 5.1.2 app-i18n/fcitx-chinese-addons: new package, add 5.1.2 Dec 12, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @liangyongxiang
Areas affected: ebuilds, profiles
Packages affected: app-i18n/fcitx-chinese-addons, app-i18n/fcitx-lua, app-i18n/fcitx-table-extra, app-i18n/fcitx-table-other, app-i18n/libime

app-i18n/fcitx-chinese-addons: @gentoo/proxy-maint (new package)
app-i18n/fcitx-lua: @gentoo/proxy-maint (new package)
app-i18n/fcitx-table-extra: @Arfrever, @gentoo/cjk
app-i18n/fcitx-table-other: @gentoo/proxy-maint (new package)
app-i18n/libime: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 760501

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 12, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-12 08:02 UTC
Newest commit scanned: 1953356
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8adb63637d/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-12 13:17 UTC
Newest commit scanned: 9f5ead5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/368e4b9522/output.html

@liangyongxiang liangyongxiang force-pushed the fcitx-next branch 2 times, most recently from 1b09d48 to d0c2420 Compare December 12, 2023 13:28
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-12 13:48 UTC
Newest commit scanned: d0c2420
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/799d0afebe/output.html

@liangyongxiang liangyongxiang marked this pull request as draft December 12, 2023 16:16
@liangyongxiang liangyongxiang marked this pull request as ready for review December 12, 2023 16:38
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-12 16:48 UTC
Newest commit scanned: ad61c91
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/788d387118/output.html

@liangyongxiang liangyongxiang marked this pull request as draft December 13, 2023 15:06
@liangyongxiang liangyongxiang marked this pull request as ready for review December 13, 2023 15:20
@liangyongxiang
Copy link
Contributor Author

Update: libime added a fix for the musl-llvm profile.

@liangyongxiang
Copy link
Contributor Author

I've actually tested it in a libvirt VM based on the openrc / systemd / musl-llvm profile and it works fine.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 16:02 UTC
Newest commit scanned: 3db1929
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/852456dc72/output.html

dlan17
dlan17 reviewed Dec 16, 2023
View reviewed changes
app-i18n/fcitx-chinese-addons/fcitx-chinese-addons-5.1.2.ebuild
LICENSE="GPL-2+ LGPL-2+"
KEYWORDS="~amd64 ~x86"
SLOT="5"
IUSE="+gui webengine +cloudpinyin +qt5 lua +opencc test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gui & qt5 will be enabled by default.. just a question, does it work fine with those USEs disabled? and no qt6 support currently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration of fcitx-chinese-addons is on fcitx5-configtool or fcitx5-config-qt. If both uses are disabled, it will work normally.

A more complete description is: When running fcitx5-configtool or fcitx5-config-qt, the configuration interface of Addons -> Pinyin will not change. If we start it through the command line, we can see the specific prompt information.

The support for qt6 is in the master branch and has not been released yet.

app-i18n/libime/libime-1.1.3.ebuild Outdated Show resolved Hide resolved
@liangyongxiang
app-i18n/libime: new package, add 1.1.3
7b17449 
libime is a library to support generic input method implementation.
It is a dependency of app-i18n/fcitx-chinese-addons

Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
@liangyongxiang
app-i18n/fcitx-lua: new package, add 5.0.11
02dfdc5 
fcitx-lua is lua support for fcitx5.
It is an optional dependency of app-i18n/fcitx-chinese-addons.

Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
@liangyongxiang
profiles/base: Default to lua-5.4 for app-i18n/fcitx-lua
d4258f7 
Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
@liangyongxiang
app-i18n/fcitx-chinese-addons: new package, add 5.1.2
53fd35a 
fcitx-chinese-addons are Chinese related addons for fcitx5.
It provides pinyin and table input method support.

Bug: https://bugs.gentoo.org/760501
Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
@liangyongxiang
app-i18n/fcitx-table-extra: add 5.1.0
cdce470 
fcitx5-table-extra provides extra table for fcitx5,
including Boshiamy, Zhengma, Cangjie, and Quick.

Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
@liangyongxiang
app-i18n/fcitx-table-other: new package, add 5.1.0
36f68b9 
fcitx-table-other provides some other tables for fcitx5,
fork from ibus-table-others, scim-tables.

Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-16 02:43 UTC
Newest commit scanned: 36f68b9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/56005cf901/output.html

@liangyongxiang liangyongxiang deleted the fcitx-next branch December 25, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlan17 dlan17 dlan17 left review comments

@liuyujielol liuyujielol liuyujielol left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package.
Projects
None yet
Milestone
No milestone
5 participants
@liangyongxiang @gentoo-repo-qa-bot @gentoo-bot @dlan17 @liuyujielol