Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fcitx5: add fcitx5-rime, and upgrade librime #34247

Closed
wants to merge 2 commits into from
Closed

Fcitx5: add fcitx5-rime, and upgrade librime #34247

wants to merge 2 commits into from

Conversation

bekcpear
Copy link
Contributor

@bekcpear bekcpear commented Dec 12, 2023 •
edited

  1. Upgrade fcitx-rime to version 5 , it conflicts with fcitx-rime:4 due to the icons.

  2. Also add a new slot 'essay' for rime-data with a newer version.

    The previous repo 'brise' for rime-data is deprecated as of Apr, 2018. However, the new rime-data is spread over several repositories, and most of them does not have a release version (including essential data). So I have to use a different slot to make it possible to select this rime-data which has a fake version number (0.0.0.[date]) that satisfies Semantic Versioning.
    The package name prefix is suggested by the upstream: https://github.com/rime/plum#install-as-shared-data

    tree: 
    app-i18n/fcitx-rime:5
    \--- app-i18n/rime-data:essay
          |--- app-i18n/rime-data-prelude (essential)
          |--- app-i18n/rime-data-array
          |--- app-i18n/rime-data-bopomofo
          |--- app-i18n/rime-data-cangjie
          |--- app-i18n/rime-data-combo-pinyin
          |--- app-i18n/rime-data-double-pinyin
          |--- app-i18n/rime-data-emoji
          |--- app-i18n/rime-data-ipa
          |--- app-i18n/rime-data-luna-pinyin
          |--- app-i18n/rime-data-middle-chinese
          |--- app-i18n/rime-data-pinyin-simp
          |--- app-i18n/rime-data-quick
          |--- app-i18n/rime-data-scj
          |--- app-i18n/rime-data-soutzoe
          |--- app-i18n/rime-data-stenotype
          |--- app-i18n/rime-data-stroke
          |--- app-i18n/rime-data-terra-pinyin
          |--- app-i18n/rime-data-wubi
          |--- app-i18n/rime-data-wugniu

    The rime-cantonese input schema is not added here duo to the ODbL license is not included in gentoo yet, this input schema may be added in the future.

  3. upgrade app-i18n/librime to 1.9.0
    This upgrade skipped over a minor version, and the time span was too long, so only the ~amd64 and ~x86 keywords are kept.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @bekcpear
Areas affected: ebuilds
Packages affected: app-i18n/fcitx-rime, app-i18n/rime-data, app-i18n/rime-data-array, app-i18n/rime-data-bopomofo, app-i18n/rime-data-cangjie...

app-i18n/fcitx-rime: @Arfrever, @dlan17, @gentoo/cjk
app-i18n/rime-data: @Arfrever, @dlan17, @gentoo/cjk
app-i18n/rime-data-array: @gentoo/proxy-maint (new package)
app-i18n/rime-data-bopomofo: @gentoo/proxy-maint (new package)
app-i18n/rime-data-cangjie: @gentoo/proxy-maint (new package)
app-i18n/rime-data-combo-pinyin: @gentoo/proxy-maint (new package)
app-i18n/rime-data-double-pinyin: @gentoo/proxy-maint (new package)
app-i18n/rime-data-emoji: @gentoo/proxy-maint (new package)
app-i18n/rime-data-ipa: @gentoo/proxy-maint (new package)
app-i18n/rime-data-luna-pinyin: @gentoo/proxy-maint (new package)
app-i18n/rime-data-middle-chinese: @gentoo/proxy-maint (new package)
app-i18n/rime-data-pinyin-simp: @gentoo/proxy-maint (new package)
app-i18n/rime-data-prelude: @gentoo/proxy-maint (new package)
app-i18n/rime-data-quick: @gentoo/proxy-maint (new package)
app-i18n/rime-data-scj: @gentoo/proxy-maint (new package)
app-i18n/rime-data-soutzoe: @gentoo/proxy-maint (new package)
app-i18n/rime-data-stenotype: @gentoo/proxy-maint (new package)
app-i18n/rime-data-stroke: @gentoo/proxy-maint (new package)
app-i18n/rime-data-terra-pinyin: @gentoo/proxy-maint (new package)
app-i18n/rime-data-wubi: @gentoo/proxy-maint (new package)
app-i18n/rime-data-wugniu: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 760501

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 12, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-12 15:18 UTC
Newest commit scanned: a4ba1fb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a9a0737c94/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 03:47 UTC
Newest commit scanned: c009992
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2270b4940c/output.html

liuyujielol
liuyujielol reviewed Dec 13, 2023
View reviewed changes
app-i18n/rime-data-array/rime-data-array-0.0.0.20221120.ebuild Outdated Show resolved Hide resolved
app-i18n/fcitx-rime/fcitx-rime-5.1.3.ebuild Outdated Show resolved Hide resolved
app-i18n/librime/librime-1.9.0.ebuild Show resolved Hide resolved
app-i18n/librime/librime-1.9.0.ebuild Outdated Show resolved Hide resolved
app-i18n/librime/librime-1.9.0.ebuild Outdated Show resolved Hide resolved
app-i18n/rime-data/rime-data-0.0.0.20230204.ebuild Outdated Show resolved Hide resolved
app-i18n/rime-data/rime-data-0.0.0.20230204.ebuild Outdated Show resolved Hide resolved
@bekcpear bekcpear force-pushed the fcitx-rime branch 2 times, most recently from f86339d to 09fad6e Compare December 13, 2023 08:25
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 08:27 UTC
Newest commit scanned: f86339d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ed35c6c126/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 08:57 UTC
Newest commit scanned: 09fad6e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/313fea430c/output.html

@bekcpear bekcpear force-pushed the fcitx-rime branch 2 times, most recently from 70a3235 to acc01f8 Compare January 1, 2024 16:01
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-01 16:14 UTC
Newest commit scanned: 70a3235
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4d83328426/output.html

@bekcpear
Copy link
Contributor Author

bekcpear commented Jan 1, 2024

Rebased to the updated master branch due to the file conflicting with ibus-rime-1.5.0.ebuild.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-01 16:42 UTC
Newest commit scanned: dfe3f95
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f2e2e350e4/output.html

@bekcpear
Copy link
Contributor Author

bekcpear commented Jan 4, 2024

Upgrade fcitx-rime:5 to 5.1.4

Due to the icon files renamed, removing the conflicting with fcitx-rime:4.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-04 15:57 UTC
Newest commit scanned: 3a47e94
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4ef350d341/output.html

@bekcpear
app-i18n/fcitx-rime: add 5.1.4
fd5550c 
Bug: https://bugs.gentoo.org/760501

Signed-off-by: Ryan Qian <i@bitbili.net>
@bekcpear
app-i18n/librime: add 1.9.0
b8dde66 
Signed-off-by: Ryan Qian <i@bitbili.net>
@bekcpear
Copy link
Contributor Author

bekcpear commented Jan 8, 2024

Give up upgrading the rime-data.

@bekcpear bekcpear changed the title Fcitx5: add fcitx5-rime, and upgrade rime-data Fcitx5: add fcitx5-rime, and upgrade librime Jan 8, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-08 07:38 UTC
Newest commit scanned: b8dde66
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/33e53b44dc/output.html

gringus pushed a commit to gringus/gentoo that referenced this pull request Jan 12, 2024
@bekcpear @gringus
app-i18n/librime: add 1.9.0
8ddfb3b 
Closes: gentoo#34247
Signed-off-by: Ryan Qian <i@bitbili.net>
Signed-off-by: Yixun Lan <dlan@gentoo.org>
@bekcpear bekcpear deleted the fcitx-rime branch January 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyujielol liuyujielol liuyujielol left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package.
Projects
None yet
Milestone
No milestone
4 participants
@bekcpear @gentoo-bot @gentoo-repo-qa-bot @liuyujielol