New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-db/mysql: add 8.3.0 #34267
base: master
Are you sure you want to change the base?
dev-db/mysql: add 8.3.0 #34267
Conversation
Pull Request assignmentSubmitter: @parona-source dev-db/mysql: @gentoo/mysql Linked bugsBugs linked: 919420 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
6843690
to
ff1c563
Compare
Pull request CI reportReport generated at: 2023-12-13 15:32 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ff1c563
to
092f049
Compare
Pull request CI reportReport generated at: 2023-12-13 19:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
092f049
to
8408b10
Compare
Pull request CI reportReport generated at: 2023-12-13 20:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some initial first pass comments
dev-db/mysql/mysql-8.2.0.ebuild
Outdated
mycmakeargs+=( -DINSTALL_MYSQLTESTDIR='' ) | ||
fi | ||
|
||
mycmakeargs+=( -DWITHOUT_CLIENTLIBS=YES ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling is we should compress a lot of these into one array assignment, the splitting here doesn't really feel like it helps readability or.. anything, really. WDYT?
Not saying we have to do that for all, but just apply some more sensible separation.
dev-db/mysql/mysql-8.2.0.ebuild
Outdated
|
||
if has sandbox ${FEATURES} ; then | ||
# bug #823656 | ||
append-cppflags -DGTEST_NO_DEATH_TEST=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we could just do this unconditionally. Also, if we're keeping if use test
conditionals, we can fold this in there.
228c903
to
1f29f2e
Compare
Pull request CI reportReport generated at: 2023-12-14 05:07 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
9687a52
to
5363856
Compare
Pull request CI reportReport generated at: 2023-12-15 05:17 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
5363856
to
41dab06
Compare
Pull request CI reportReport generated at: 2023-12-15 05:32 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
e73d156
to
7beedee
Compare
Pull request CI reportReport generated at: 2023-12-15 05:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-12-15 06:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
7beedee
to
5b876d3
Compare
I decided to drop mips, will have to see if the mips project has interest in testing even if I just masked for all the 32bit variants... profiles/arch/mips/ |
Pull request CI reportReport generated at: 2023-12-15 18:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
5b876d3
to
4211700
Compare
Pull request CI reportReport generated at: 2024-01-25 09:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
4211700
to
6d43f82
Compare
6d43f82
to
0184ca4
Compare
Clientlibs needs a proper check. Otherwise builds and passes tests. |
Pull request CI reportReport generated at: 2024-01-25 16:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
0184ca4
to
8c6925a
Compare
Pull request CI reportReport generated at: 2024-01-25 18:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
8c6925a
to
abf77a9
Compare
Pull request CI reportReport generated at: 2024-01-26 11:28 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
abf77a9
to
7420e35
Compare
Signed-off-by: Alfred Wingate <parona@protonmail.com>
7420e35
to
f29e0d5
Compare
Closes: https://bugs.gentoo.org/919420 Signed-off-by: Alfred Wingate <parona@protonmail.com>
f29e0d5
to
48bd7b7
Compare
Pull request CI reportReport generated at: 2024-02-07 00:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-02-07 01:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/919420
Rebased patches from https://github.com/parona-source/mysql-server/tree/mysql-8.2.0-patches
Draft for now.
All 32-bit support has been dropped, so keywording for architectures where 32-bit and 64-bit are differentiated in sub profiles needs to be handled.
Dropped latin1, anyone requiring(?) this still can use MYSQL_DEFAULT_CHARSET and MYSQL_DEFAULT_COLLATION.
Long overdue caching_sha2_password set as default authentication plugin, all version in Gentoo support it now and mysql_native_password has been deprecated since 8.0.34.
And as this is a part of the new innovation releases it naturally shouldn't be stable keyworded.
https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/
Not sure how slots should be handled with these. Currently going with giving slots to every x.y release as you cant CLONE between these releases.