Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-db/mysql: add 8.3.0 #34267

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

parona-source
Copy link
Contributor

@parona-source parona-source commented Dec 13, 2023

Closes: https://bugs.gentoo.org/919420

Rebased patches from https://github.com/parona-source/mysql-server/tree/mysql-8.2.0-patches

Draft for now.

All 32-bit support has been dropped, so keywording for architectures where 32-bit and 64-bit are differentiated in sub profiles needs to be handled.

Dropped latin1, anyone requiring(?) this still can use MYSQL_DEFAULT_CHARSET and MYSQL_DEFAULT_COLLATION.

Long overdue caching_sha2_password set as default authentication plugin, all version in Gentoo support it now and mysql_native_password has been deprecated since 8.0.34.

And as this is a part of the new innovation releases it naturally shouldn't be stable keyworded.

Support for Innovation releases is limited until the next minor release (Innovation or LTS). The current cadence goal is to have an Innovation release every quarter, incrementing the minor version number (eg. 8.2, 8.3, etc.). Patch releases within Innovation releases are possible but are less likely to happen.

https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/

Not sure how slots should be handled with these. Currently going with giving slots to every x.y release as you cant CLONE between these releases.

image

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @parona-source
Areas affected: ebuilds
Packages affected: dev-db/mysql

dev-db/mysql: @gentoo/mysql

Linked bugs

Bugs linked: 919420


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 13, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 15:32 UTC
Newest commit scanned: ff1c563
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c548a591e4/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 19:52 UTC
Newest commit scanned: 092f049
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/13ffd6de65/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 20:12 UTC
Newest commit scanned: 8408b10
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/51b57a518f/output.html

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some initial first pass comments

dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
mycmakeargs+=( -DINSTALL_MYSQLTESTDIR='' )
fi

mycmakeargs+=( -DWITHOUT_CLIENTLIBS=YES )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is we should compress a lot of these into one array assignment, the splitting here doesn't really feel like it helps readability or.. anything, really. WDYT?

Not saying we have to do that for all, but just apply some more sensible separation.

dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved

if has sandbox ${FEATURES} ; then
# bug #823656
append-cppflags -DGTEST_NO_DEATH_TEST=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we could just do this unconditionally. Also, if we're keeping if use test conditionals, we can fold this in there.

dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
dev-db/mysql/mysql-8.2.0.ebuild Outdated Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-14 05:07 UTC
Newest commit scanned: 1f29f2e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8081b2c7da/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-15 05:17 UTC
Newest commit scanned: 9687a52
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/014aa31255/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-15 05:32 UTC
Newest commit scanned: 41dab06
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3d96e2fd15/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-15 05:52 UTC
Newest commit scanned: e73d156
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a199c68d72/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-15 06:08 UTC
Newest commit scanned: 7beedee
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a50a56d5c9/output.html

@parona-source
Copy link
Contributor Author

I decided to drop mips, will have to see if the mips project has interest in testing even if I just masked for all the 32bit variants...

profiles/arch/mips/
profiles/arch/mips/mips64
profiles/arch/mips/mips64/multilib
profiles/arch/mips/mips64/multilib/o32
profiles/arch/mips/mips64/multilib/n32
profiles/arch/mips/mips64/multilib/n64
profiles/arch/mips/mips64/n32
profiles/arch/mips/mips64/n64
profiles/arch/mips/o32
profiles/arch/mips/mipsel
profiles/arch/mips/mipsel/mips64el
profiles/arch/mips/mipsel/mips64el/multilib
profiles/arch/mips/mipsel/mips64el/multilib/o32
profiles/arch/mips/mipsel/mips64el/multilib/n32
profiles/arch/mips/mipsel/mips64el/multilib/n64
profiles/arch/mips/mipsel/mips64el/n32
profiles/arch/mips/mipsel/mips64el/n64
profiles/arch/mips/mipsel/o32

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-15 18:58 UTC
Newest commit scanned: 5b876d3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5c2d49a84f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-25 09:37 UTC
Newest commit scanned: 4211700
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fd2cf96cec/output.html

@parona-source
Copy link
Contributor Author

parona-source commented Jan 25, 2024

Clientlibs needs a proper check. Otherwise builds and passes tests.

@parona-source parona-source changed the title dev-db/mysql: add 8.2.0 dev-db/mysql: add 8.3.0 Jan 25, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-25 16:52 UTC
Newest commit scanned: 0184ca4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5f218f6ecb/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-25 18:08 UTC
Newest commit scanned: 8c6925a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/248d3acaf9/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-26 11:28 UTC
Newest commit scanned: abf77a9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/39733764c7/output.html

Signed-off-by: Alfred Wingate <parona@protonmail.com>
Closes: https://bugs.gentoo.org/919420
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-07 00:53 UTC
Newest commit scanned: f29e0d5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/306915e1ed/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-07 01:37 UTC
Newest commit scanned: 48bd7b7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c82c2d15b4/output.html

@thesamesam thesamesam self-requested a review April 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants