Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/colorful: new package, add 0.5.5 #34300

Closed
wants to merge 1 commit into from

Conversation

MocioF
Copy link
Contributor

@MocioF MocioF commented Dec 15, 2023

I don't think this package is under active development, but it is a dependency needed to add net-analyzer/pontos to gentoo.
net-analyzer/pontos is a package to build the utility software developed by Greenbone (https://github.com/greenbone/pontos) and is a dependency required to run tests on some of the packages that together make up the Greenbone Vulnerability Management suite. i.e. It is needed if we want to remove RESTRICT="test" in net-analyzer/python-gvm (and more)

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @MocioF
Areas affected: ebuilds
Packages affected: dev-python/colorful

dev-python/colorful: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Dec 15, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-15 22:43 UTC
Newest commit scanned: da70a31
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/34174934fa/output.html

Comment on lines 27 to 31
BDEPEND="
test? (
dev-python/pytest[${PYTHON_USEDEP}]
)
"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distutils_enable_tests takes care of that.

dev-python/colorful/colorful-0.5.5.ebuild Show resolved Hide resolved
sed -i \
-e "s/find_packages/find_namespace_packages/" \
-e "s/(exclude=\['\*tests\*'\])/(exclude=\['\*tests\*'\, '\*examples\*'\])/" \
setup.py || die "Error fixing setup.py for >=PEP420"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setup.py || die "Error fixing setup.py for >=PEP420"
setup.py || die "Error fixing setup.py for >=PEP420"

Otherwise it looks as if you were actually trying to call setup.py, rather than it being part of the above command.

dev-python/colorful/metadata.xml Show resolved Hide resolved
dev-python/colorful/metadata.xml Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-16 18:58 UTC
Newest commit scanned: 19fe5b3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c6ac49f80a/output.html

Comment on lines 24 to 25
IUSE="test"
RESTRICT="!test? ( test )"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are added by distutils_enable_tests as well. Otherwise it couldn't add the dep.


inherit distutils-r1

DESCRIPTION="Terminal string styling done right, in Python."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DESCRIPTION="Terminal string styling done right, in Python."
DESCRIPTION="Terminal string styling done right, in Python"

DESCRIPTION="Terminal string styling done right, in Python."
HOMEPAGE="
https://pypi.org/project/colorful/
https://github.com/timofurrer/colorful
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://github.com/timofurrer/colorful
https://github.com/timofurrer/colorful/

dev-python/colorful/colorful-0.5.5.ebuild Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-17 09:03 UTC
Newest commit scanned: e36c3c9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a491eeb46b/output.html

Signed-off-by: Giuseppe Foti <foti.giuseppe@gmail.com>
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@MocioF MocioF deleted the add-colorful branch December 17, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants